raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-15 22:41:38 +00:00
Code Issues Projects Releases Wiki Activity

gpio: bcm-virt: Fix the get() method

Browse Source 
The get() method does not understand the on-the-wire encoding of the
remote GPIO states, thinking they are simple on/off bits when they are
really pairs of 16-bit counts. Rewrite the get() handler to return the
value last written, which will eventually match the actual GPIO state
if there are no other changes.

See: https://github.com/raspberrypi/linux/issues/4638

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This commit is contained in:
Phil Elwell
2021-10-19 11:23:43 +01:00
parent a4407c4485
commit 03ab8875d1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-bcm-virt.c
View File

@@ -49,7 +49,7 @@ static int brcmvirt_gpio_get(struct gpio_chip *gc, unsigned off)
unsigned v; unsigned v;
gpio = container_of(gc, struct brcmvirt_gpio, gc); gpio = container_of(gc, struct brcmvirt_gpio, gc);
v = readl(gpio->ts_base + off); v = readl(gpio->ts_base + off);
return (v >> off) & 1; return (s16)((v >> 16) - v) > 0;
} }
static void brcmvirt_gpio_set(struct gpio_chip *gc, unsigned off, int val) static void brcmvirt_gpio_set(struct gpio_chip *gc, unsigned off, int val)