raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

net: lan78xx: Ack pending PHY ints when resetting

Browse Source 
lan78xx_link_reset explicitly clears the MAC's view of the PHY's IRQ
status. In doing so it potentially leaves the PHY with a pending
interrupt that will never be acknowledged, at which point no further
interrupts will be generated.

Avoid the problem by acknowledging any pending PHY interrupt after
clearing the MAC's status bit.

See: https://github.com/raspberrypi/linux/issues/2937

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This commit is contained in:
Phil Elwell
2020-12-15 16:38:37 +00:00
committed by Dom Cobley
parent a9e8ec1b7a
commit 07eb98d5f3
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/usb/lan78xx.c
View File

@@ -1435,6 +1435,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev)
if (unlikely(ret < 0)) if (unlikely(ret < 0))
return ret; return ret;
/* Acknowledge any pending PHY interrupt, lest it be the last */
phy_read(phydev, LAN88XX_INT_STS);
mutex_lock(&phydev->lock); mutex_lock(&phydev->lock);
phy_read_status(phydev); phy_read_status(phydev);
link = phydev->link; link = phydev->link;