raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-11 12:30:09 +00:00
Code Issues Projects Releases Wiki Activity

net: phy: Support speed selection for PHY loopback

Browse Source 
phy_loopback() leaves it to the PHY driver to select the speed of the
loopback mode. Thus, the speed of the loopback mode depends on the PHY
driver in use.

Add support for speed selection to phy_loopback() to enable loopback
with defined speeds. Ensure that link up is signaled if speed changes
as speed is not allowed to change during link up. Link down and up is
necessary for a new speed.

Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20250312203010.47429-3-gerhard@engleder-embedded.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Gerhard Engleder
2025-03-12 21:30:07 +01:00
committed by Paolo Abeni
parent 45456e38c4
commit 0d60fd5032
9 changed files with 100 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
drivers/net/phy/phy.c
View File

@@ -1707,6 +1707,93 @@ void phy_mac_interrupt(struct phy_device *phydev)
}
EXPORT_SYMBOL(phy_mac_interrupt);
/**
* phy_loopback - Configure loopback mode of PHY
* @phydev: target phy_device struct
* @enable: enable or disable loopback mode
* @speed: enable loopback mode with speed
*
* Configure loopback mode of PHY and signal link down and link up if speed is
* changing.
*
* Return: 0 on success, negative error code on failure.
*/
int phy_loopback(struct phy_device *phydev, bool enable, int speed)
{
bool link_up = false;
int ret = 0;
if (!phydev->drv)
return -EIO;
mutex_lock(&phydev->lock);
if (enable && phydev->loopback_enabled) {
ret = -EBUSY;
goto out;
}
if (!enable && !phydev->loopback_enabled) {
ret = -EINVAL;
goto out;
}
if (enable) {
/*
* Link up is signaled with a defined speed. If speed changes,
* then first link down and after that link up needs to be
* signaled.
*/
if (phydev->link && phydev->state == PHY_RUNNING) {
/* link is up and signaled */
if (speed && phydev->speed != speed) {
/* signal link down and up for new speed */
phydev->link = false;
phydev->state = PHY_NOLINK;
phy_link_down(phydev);
link_up = true;
}
} else {
/* link is not signaled */
if (speed) {
/* signal link up for new speed */
link_up = true;
}
}
}
if (phydev->drv->set_loopback)
ret = phydev->drv->set_loopback(phydev, enable, speed);
else
ret = genphy_loopback(phydev, enable, speed);
if (ret) {
if (enable) {
/* try to restore link if enabling loopback fails */
if (phydev->drv->set_loopback)
phydev->drv->set_loopback(phydev, false, 0);
else
genphy_loopback(phydev, false, 0);
}
goto out;
}
if (link_up) {
phydev->link = true;
phydev->state = PHY_RUNNING;
phy_link_up(phydev);
}
phydev->loopback_enabled = enable;
out:
mutex_unlock(&phydev->lock);
return ret;
}
EXPORT_SYMBOL(phy_loopback);
/**
* phy_eee_tx_clock_stop_capable() - indicate whether the MAC can stop tx clock
* @phydev: target phy_device struct