raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

[media] s5h1420: fix a buffer overflow when checking userspace params

Browse Source 
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up to 7 values:
	drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7

Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Mauro Carvalho Chehab
2015-04-28 18:34:40 -03:00
parent 451dfbe9f1
commit 12f4543f5d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/dvb-frontends/s5h1420.c
View File

@@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (struct dvb_frontend* fe,
int result = 0; int result = 0;
dprintk("enter %s\n", __func__); dprintk("enter %s\n", __func__);
if (cmd->msg_len > 8) if (cmd->msg_len > sizeof(cmd->msg))
return -EINVAL; return -EINVAL;
/* setup for DISEQC */ /* setup for DISEQC */