raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup"

Browse Source 
Commit 6dce5aa59e ("PCI: xgene: Use inbound resources for setup")
killed PCIe on my XGene-1 box (a Mustang board). The machine itself
is still alive, but half of its storage (over NVMe) is gone, and the
NVMe driver just times out.

Note that this machine boots with a device tree provided by the
UEFI firmware (2016 vintage), which could well be non conformant
with the spec, hence the breakage.

With the patch reverted, the box boots 5.17-rc8 with flying colors.

Link: https://lore.kernel.org/all/Yf2wTLjmcRj+AbDv@xps13.dannf
Link: https://lore.kernel.org/r/20220321104843.949645-2-maz@kernel.org
Fixes: 6dce5aa59e ("PCI: xgene: Use inbound resources for setup")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Cc: Toan Le <toan@os.amperecomputing.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Krzysztof Wilczyński <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Stéphane Graber <stgraber@ubuntu.com>
Cc: dann frazier <dann.frazier@canonical.com>
This commit is contained in:
Marc Zyngier
2022-03-21 10:48:42 +00:00
committed by Lorenzo Pieralisi
parent e783362eb5
commit 1874b6d7ab
1 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/pci/controller/pci-xgene.c
View File

@@ -479,28 +479,27 @@ static int xgene_pcie_select_ib_reg(u8 *ib_reg_mask, u64 size)
} }
static void xgene_pcie_setup_ib_reg(struct xgene_pcie *port, static void xgene_pcie_setup_ib_reg(struct xgene_pcie *port,
struct resource_entry *entry, struct of_pci_range *range, u8 *ib_reg_mask)
u8 *ib_reg_mask)
{ {
void __iomem *cfg_base = port->cfg_base; void __iomem *cfg_base = port->cfg_base;
struct device *dev = port->dev; struct device *dev = port->dev;
void __iomem *bar_addr; void __iomem *bar_addr;
u32 pim_reg; u32 pim_reg;
u64 cpu_addr = entry->res->start; u64 cpu_addr = range->cpu_addr;
u64 pci_addr = cpu_addr - entry->offset; u64 pci_addr = range->pci_addr;
u64 size = resource_size(entry->res); u64 size = range->size;
u64 mask = ~(size - 1) | EN_REG; u64 mask = ~(size - 1) | EN_REG;
u32 flags = PCI_BASE_ADDRESS_MEM_TYPE_64; u32 flags = PCI_BASE_ADDRESS_MEM_TYPE_64;
u32 bar_low; u32 bar_low;
int region; int region;
region = xgene_pcie_select_ib_reg(ib_reg_mask, size); region = xgene_pcie_select_ib_reg(ib_reg_mask, range->size);
if (region < 0) { if (region < 0) {
dev_warn(dev, "invalid pcie dma-range config\n"); dev_warn(dev, "invalid pcie dma-range config\n");
return; return;
} }
if (entry->res->flags & IORESOURCE_PREFETCH) if (range->flags & IORESOURCE_PREFETCH)
flags |= PCI_BASE_ADDRESS_MEM_PREFETCH; flags |= PCI_BASE_ADDRESS_MEM_PREFETCH;
bar_low = pcie_bar_low_val((u32)cpu_addr, flags); bar_low = pcie_bar_low_val((u32)cpu_addr, flags);
@@ -531,13 +530,25 @@ static void xgene_pcie_setup_ib_reg(struct xgene_pcie *port,
static int xgene_pcie_parse_map_dma_ranges(struct xgene_pcie *port) static int xgene_pcie_parse_map_dma_ranges(struct xgene_pcie *port)
{ {
struct pci_host_bridge *bridge = pci_host_bridge_from_priv(port); struct device_node *np = port->node;
struct resource_entry *entry; struct of_pci_range range;
struct of_pci_range_parser parser;
struct device *dev = port->dev;
u8 ib_reg_mask = 0; u8 ib_reg_mask = 0;
resource_list_for_each_entry(entry, &bridge->dma_ranges) if (of_pci_dma_range_parser_init(&parser, np)) {
xgene_pcie_setup_ib_reg(port, entry, &ib_reg_mask); dev_err(dev, "missing dma-ranges property\n");
return -EINVAL;
}
/* Get the dma-ranges from DT */
for_each_of_pci_range(&parser, &range) {
u64 end = range.cpu_addr + range.size - 1;
dev_dbg(dev, "0x%08x 0x%016llx..0x%016llx -> 0x%016llx\n",
range.flags, range.cpu_addr, end, range.pci_addr);
xgene_pcie_setup_ib_reg(port, &range, &ib_reg_mask);
}
return 0; return 0;
} }