raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

net: sched: use temporary variable for actions indexes

Browse Source 
[ Upstream commit 7be8ef2cdb ]

Currently init call of all actions (except ipt) init their 'parm'
structure as a direct pointer to nla data in skb. This leads to race
condition when some of the filter actions were initialized successfully
(and were assigned with idr action index that was written directly
into nla data), but then were deleted and retried (due to following
action module missing or classifier-initiated retry), in which case
action init code tries to insert action to idr with index that was
assigned on previous iteration. During retry the index can be reused
by another action that was inserted concurrently, which causes
unintended action sharing between filters.
To fix described race condition, save action idr index to temporary
stack-allocated variable instead on nla data.

Fixes: 0190c1d452 ("net: sched: atomically check-allocate action")
Signed-off-by: Dmytro Linkin <dmitrolin@mellanox.com>
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dmytro Linkin
2019-08-01 13:02:51 +00:00
committed by Greg Kroah-Hartman
parent f08d8c217a
commit 22d487d30a
15 changed files with 85 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
net/sched/act_bpf.c
View File

@@ -285,6 +285,7 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla,
struct tcf_bpf *prog; struct tcf_bpf *prog;
bool is_bpf, is_ebpf; bool is_bpf, is_ebpf;
int ret, res = 0; int ret, res = 0;
u32 index;
if (!nla) if (!nla)
return -EINVAL; return -EINVAL;
@@ -298,13 +299,13 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_ACT_BPF_PARMS]); parm = nla_data(tb[TCA_ACT_BPF_PARMS]);
index = parm->index;
ret = tcf_idr_check_alloc(tn, &parm->index, act, bind); ret = tcf_idr_check_alloc(tn, &index, act, bind);
if (!ret) { if (!ret) {
ret = tcf_idr_create(tn, parm->index, est, act, ret = tcf_idr_create(tn, index, est, act,
&act_bpf_ops, bind, true); &act_bpf_ops, bind, true);
if (ret < 0) { if (ret < 0) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

9
net/sched/act_connmark.c
View File

@@ -103,6 +103,7 @@ static int tcf_connmark_init(struct net *net, struct nlattr *nla,
struct tcf_connmark_info *ci; struct tcf_connmark_info *ci;
struct tc_connmark *parm; struct tc_connmark *parm;
int ret = 0, err; int ret = 0, err;
u32 index;
if (!nla) if (!nla)
return -EINVAL; return -EINVAL;
@@ -116,13 +117,13 @@ static int tcf_connmark_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_CONNMARK_PARMS]); parm = nla_data(tb[TCA_CONNMARK_PARMS]);
index = parm->index;
ret = tcf_idr_check_alloc(tn, &parm->index, a, bind); ret = tcf_idr_check_alloc(tn, &index, a, bind);
if (!ret) { if (!ret) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_connmark_ops, bind, false); &act_connmark_ops, bind, false);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

9
net/sched/act_csum.c
View File

@@ -52,6 +52,7 @@ static int tcf_csum_init(struct net *net, struct nlattr *nla,
struct tc_csum *parm; struct tc_csum *parm;
struct tcf_csum *p; struct tcf_csum *p;
int ret = 0, err; int ret = 0, err;
u32 index;
if (nla == NULL) if (nla == NULL)
return -EINVAL; return -EINVAL;
@@ -64,13 +65,13 @@ static int tcf_csum_init(struct net *net, struct nlattr *nla,
if (tb[TCA_CSUM_PARMS] == NULL) if (tb[TCA_CSUM_PARMS] == NULL)
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_CSUM_PARMS]); parm = nla_data(tb[TCA_CSUM_PARMS]);
index = parm->index;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (!err) { if (!err) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_csum_ops, bind, true); &act_csum_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

8
net/sched/act_gact.c
View File

@@ -61,6 +61,7 @@ static int tcf_gact_init(struct net *net, struct nlattr *nla,
struct tc_gact *parm; struct tc_gact *parm;
struct tcf_gact *gact; struct tcf_gact *gact;
int ret = 0; int ret = 0;
u32 index;
int err; int err;
#ifdef CONFIG_GACT_PROB #ifdef CONFIG_GACT_PROB
struct tc_gact_p *p_parm = NULL; struct tc_gact_p *p_parm = NULL;
@@ -77,6 +78,7 @@ static int tcf_gact_init(struct net *net, struct nlattr *nla,
if (tb[TCA_GACT_PARMS] == NULL) if (tb[TCA_GACT_PARMS] == NULL)
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_GACT_PARMS]); parm = nla_data(tb[TCA_GACT_PARMS]);
index = parm->index;
#ifndef CONFIG_GACT_PROB #ifndef CONFIG_GACT_PROB
if (tb[TCA_GACT_PROB] != NULL) if (tb[TCA_GACT_PROB] != NULL)
@@ -94,12 +96,12 @@ static int tcf_gact_init(struct net *net, struct nlattr *nla,
} }
#endif #endif
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (!err) { if (!err) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_gact_ops, bind, true); &act_gact_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

8
net/sched/act_ife.c
View File

@@ -479,6 +479,7 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
u8 *saddr = NULL; u8 *saddr = NULL;
bool exists = false; bool exists = false;
int ret = 0; int ret = 0;
u32 index;
int err; int err;
if (!nla) { if (!nla) {
@@ -507,7 +508,8 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
if (!p) if (!p)
return -ENOMEM; return -ENOMEM;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) { if (err < 0) {
kfree(p); kfree(p);
return err; return err;
@@ -519,10 +521,10 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
} }
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, &act_ife_ops, ret = tcf_idr_create(tn, index, est, a, &act_ife_ops,
bind, true); bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
kfree(p); kfree(p);
return ret; return ret;
} }

13
net/sched/act_mirred.c
View File

@@ -101,6 +101,7 @@ static int tcf_mirred_init(struct net *net, struct nlattr *nla,
struct net_device *dev; struct net_device *dev;
bool exists = false; bool exists = false;
int ret, err; int ret, err;
u32 index;
if (!nla) { if (!nla) {
NL_SET_ERR_MSG_MOD(extack, "Mirred requires attributes to be passed"); NL_SET_ERR_MSG_MOD(extack, "Mirred requires attributes to be passed");
@@ -115,8 +116,8 @@ static int tcf_mirred_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
} }
parm = nla_data(tb[TCA_MIRRED_PARMS]); parm = nla_data(tb[TCA_MIRRED_PARMS]);
index = parm->index;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -133,21 +134,21 @@ static int tcf_mirred_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
NL_SET_ERR_MSG_MOD(extack, "Unknown mirred option"); NL_SET_ERR_MSG_MOD(extack, "Unknown mirred option");
return -EINVAL; return -EINVAL;
} }
if (!exists) { if (!exists) {
if (!parm->ifindex) { if (!parm->ifindex) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
NL_SET_ERR_MSG_MOD(extack, "Specified device does not exist"); NL_SET_ERR_MSG_MOD(extack, "Specified device does not exist");
return -EINVAL; return -EINVAL;
} }
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_mirred_ops, bind, true); &act_mirred_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

9
net/sched/act_nat.c
View File

@@ -44,6 +44,7 @@ static int tcf_nat_init(struct net *net, struct nlattr *nla, struct nlattr *est,
struct tc_nat *parm; struct tc_nat *parm;
int ret = 0, err; int ret = 0, err;
struct tcf_nat *p; struct tcf_nat *p;
u32 index;
if (nla == NULL) if (nla == NULL)
return -EINVAL; return -EINVAL;
@@ -56,13 +57,13 @@ static int tcf_nat_init(struct net *net, struct nlattr *nla, struct nlattr *est,
if (tb[TCA_NAT_PARMS] == NULL) if (tb[TCA_NAT_PARMS] == NULL)
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_NAT_PARMS]); parm = nla_data(tb[TCA_NAT_PARMS]);
index = parm->index;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (!err) { if (!err) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_nat_ops, bind, false); &act_nat_ops, bind, false);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

10
net/sched/act_pedit.c
View File

@@ -149,6 +149,7 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla,
struct tcf_pedit *p; struct tcf_pedit *p;
int ret = 0, err; int ret = 0, err;
int ksize; int ksize;
u32 index;
if (!nla) { if (!nla) {
NL_SET_ERR_MSG_MOD(extack, "Pedit requires attributes to be passed"); NL_SET_ERR_MSG_MOD(extack, "Pedit requires attributes to be passed");
@@ -179,18 +180,19 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla,
if (IS_ERR(keys_ex)) if (IS_ERR(keys_ex))
return PTR_ERR(keys_ex); return PTR_ERR(keys_ex);
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (!err) { if (!err) {
if (!parm->nkeys) { if (!parm->nkeys) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
NL_SET_ERR_MSG_MOD(extack, "Pedit requires keys to be passed"); NL_SET_ERR_MSG_MOD(extack, "Pedit requires keys to be passed");
ret = -EINVAL; ret = -EINVAL;
goto out_free; goto out_free;
} }
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_pedit_ops, bind, false); &act_pedit_ops, bind, false);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
goto out_free; goto out_free;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

8
net/sched/act_police.c
View File

@@ -57,6 +57,7 @@ static int tcf_police_init(struct net *net, struct nlattr *nla,
struct tc_action_net *tn = net_generic(net, police_net_id); struct tc_action_net *tn = net_generic(net, police_net_id);
struct tcf_police_params *new; struct tcf_police_params *new;
bool exists = false; bool exists = false;
u32 index;
if (nla == NULL) if (nla == NULL)
return -EINVAL; return -EINVAL;
@@ -73,7 +74,8 @@ static int tcf_police_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_POLICE_TBF]); parm = nla_data(tb[TCA_POLICE_TBF]);
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -81,10 +83,10 @@ static int tcf_police_init(struct net *net, struct nlattr *nla,
return 0; return 0;
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, NULL, a, ret = tcf_idr_create(tn, index, NULL, a,
&act_police_ops, bind, true); &act_police_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

10
net/sched/act_sample.c
View File

@@ -41,8 +41,8 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla,
struct tc_action_net *tn = net_generic(net, sample_net_id); struct tc_action_net *tn = net_generic(net, sample_net_id);
struct nlattr *tb[TCA_SAMPLE_MAX + 1]; struct nlattr *tb[TCA_SAMPLE_MAX + 1];
struct psample_group *psample_group; struct psample_group *psample_group;
u32 psample_group_num, rate, index;
struct tcf_chain *goto_ch = NULL; struct tcf_chain *goto_ch = NULL;
u32 psample_group_num, rate;
struct tc_sample *parm; struct tc_sample *parm;
struct tcf_sample *s; struct tcf_sample *s;
bool exists = false; bool exists = false;
@@ -59,8 +59,8 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_SAMPLE_PARMS]); parm = nla_data(tb[TCA_SAMPLE_PARMS]);
index = parm->index;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -68,10 +68,10 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla,
return 0; return 0;
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_sample_ops, bind, true); &act_sample_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }
ret = ACT_P_CREATED; ret = ACT_P_CREATED;

10
net/sched/act_simple.c
View File

@@ -95,6 +95,7 @@ static int tcf_simp_init(struct net *net, struct nlattr *nla,
struct tcf_defact *d; struct tcf_defact *d;
bool exists = false; bool exists = false;
int ret = 0, err; int ret = 0, err;
u32 index;
if (nla == NULL) if (nla == NULL)
return -EINVAL; return -EINVAL;
@@ -108,7 +109,8 @@ static int tcf_simp_init(struct net *net, struct nlattr *nla,
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_DEF_PARMS]); parm = nla_data(tb[TCA_DEF_PARMS]);
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -119,15 +121,15 @@ static int tcf_simp_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EINVAL; return -EINVAL;
} }
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_simp_ops, bind, false); &act_simp_ops, bind, false);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

11
net/sched/act_skbedit.c
View File

@@ -99,6 +99,7 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
u16 *queue_mapping = NULL, *ptype = NULL; u16 *queue_mapping = NULL, *ptype = NULL;
bool exists = false; bool exists = false;
int ret = 0, err; int ret = 0, err;
u32 index;
if (nla == NULL) if (nla == NULL)
return -EINVAL; return -EINVAL;
@@ -146,8 +147,8 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
} }
parm = nla_data(tb[TCA_SKBEDIT_PARMS]); parm = nla_data(tb[TCA_SKBEDIT_PARMS]);
index = parm->index;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -158,15 +159,15 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EINVAL; return -EINVAL;
} }
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_skbedit_ops, bind, true); &act_skbedit_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

11
net/sched/act_skbmod.c
View File

@@ -87,12 +87,12 @@ static int tcf_skbmod_init(struct net *net, struct nlattr *nla,
struct tcf_skbmod_params *p, *p_old; struct tcf_skbmod_params *p, *p_old;
struct tcf_chain *goto_ch = NULL; struct tcf_chain *goto_ch = NULL;
struct tc_skbmod *parm; struct tc_skbmod *parm;
u32 lflags = 0, index;
struct tcf_skbmod *d; struct tcf_skbmod *d;
bool exists = false; bool exists = false;
u8 *daddr = NULL; u8 *daddr = NULL;
u8 *saddr = NULL; u8 *saddr = NULL;
u16 eth_type = 0; u16 eth_type = 0;
u32 lflags = 0;
int ret = 0, err; int ret = 0, err;
if (!nla) if (!nla)
@@ -122,10 +122,11 @@ static int tcf_skbmod_init(struct net *net, struct nlattr *nla,
} }
parm = nla_data(tb[TCA_SKBMOD_PARMS]); parm = nla_data(tb[TCA_SKBMOD_PARMS]);
index = parm->index;
if (parm->flags & SKBMOD_F_SWAPMAC) if (parm->flags & SKBMOD_F_SWAPMAC)
lflags = SKBMOD_F_SWAPMAC; lflags = SKBMOD_F_SWAPMAC;
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -136,15 +137,15 @@ static int tcf_skbmod_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EINVAL; return -EINVAL;
} }
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_skbmod_ops, bind, true); &act_skbmod_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

8
net/sched/act_tunnel_key.c
View File

@@ -225,6 +225,7 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
__be16 flags = 0; __be16 flags = 0;
u8 tos, ttl; u8 tos, ttl;
int ret = 0; int ret = 0;
u32 index;
int err; int err;
if (!nla) { if (!nla) {
@@ -245,7 +246,8 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
} }
parm = nla_data(tb[TCA_TUNNEL_KEY_PARMS]); parm = nla_data(tb[TCA_TUNNEL_KEY_PARMS]);
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -345,7 +347,7 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
} }
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_tunnel_key_ops, bind, true); &act_tunnel_key_ops, bind, true);
if (ret) { if (ret) {
NL_SET_ERR_MSG(extack, "Cannot create TC IDR"); NL_SET_ERR_MSG(extack, "Cannot create TC IDR");
@@ -403,7 +405,7 @@ err_out:
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }

16
net/sched/act_vlan.c
View File

@@ -116,6 +116,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
u8 push_prio = 0; u8 push_prio = 0;
bool exists = false; bool exists = false;
int ret = 0, err; int ret = 0, err;
u32 index;
if (!nla) if (!nla)
return -EINVAL; return -EINVAL;
@@ -128,7 +129,8 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
if (!tb[TCA_VLAN_PARMS]) if (!tb[TCA_VLAN_PARMS])
return -EINVAL; return -EINVAL;
parm = nla_data(tb[TCA_VLAN_PARMS]); parm = nla_data(tb[TCA_VLAN_PARMS]);
err = tcf_idr_check_alloc(tn, &parm->index, a, bind); index = parm->index;
err = tcf_idr_check_alloc(tn, &index, a, bind);
if (err < 0) if (err < 0)
return err; return err;
exists = err; exists = err;
@@ -144,7 +146,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EINVAL; return -EINVAL;
} }
push_vid = nla_get_u16(tb[TCA_VLAN_PUSH_VLAN_ID]); push_vid = nla_get_u16(tb[TCA_VLAN_PUSH_VLAN_ID]);
@@ -152,7 +154,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -ERANGE; return -ERANGE;
} }
@@ -166,7 +168,7 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EPROTONOSUPPORT; return -EPROTONOSUPPORT;
} }
} else { } else {
@@ -180,16 +182,16 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla,
if (exists) if (exists)
tcf_idr_release(*a, bind); tcf_idr_release(*a, bind);
else else
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return -EINVAL; return -EINVAL;
} }
action = parm->v_action; action = parm->v_action;
if (!exists) { if (!exists) {
ret = tcf_idr_create(tn, parm->index, est, a, ret = tcf_idr_create(tn, index, est, a,
&act_vlan_ops, bind, true); &act_vlan_ops, bind, true);
if (ret) { if (ret) {
tcf_idr_cleanup(tn, parm->index); tcf_idr_cleanup(tn, index);
return ret; return ret;
} }