raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

coresight: cti: Add PM runtime call in enable_store

Browse Source 
[ Upstream commit eff674a9b8 ]

In commit 6746eae4bb ("coresight: cti: Fix hang in cti_disable_hw()")
PM runtime calls are removed from cti_enable_hw/cti_disable_hw. When
enabling CTI by writing enable sysfs node, clock for accessing CTI
register won't be enabled. Device will crash due to register access
issue. Add PM runtime call in enable_store to fix this issue.

Fixes: 6746eae4bb ("coresight: cti: Fix hang in cti_disable_hw()")
Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
[Change to only call pm_runtime_put if a disable happened]
Tested-by: Jinlong Mao <quic_jinlmao@quicinc.com>
Signed-off-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230110110736.2709917-3-james.clark@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Mao Jinlong
2023-01-10 11:07:35 +00:00
committed by Greg Kroah-Hartman
parent 14d3414b9d
commit 2551b9d4df
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/hwtracing/coresight/coresight-cti-sysfs.c
View File

@@ -108,10 +108,19 @@ static ssize_t enable_store(struct device *dev,
if (ret) if (ret)
return ret; return ret;
if (val) if (val) {
ret = pm_runtime_resume_and_get(dev->parent);
if (ret)
return ret;
ret = cti_enable(drvdata->csdev); ret = cti_enable(drvdata->csdev);
else if (ret)
pm_runtime_put(dev->parent);
} else {
ret = cti_disable(drvdata->csdev); ret = cti_disable(drvdata->csdev);
if (!ret)
pm_runtime_put(dev->parent);
}
if (ret) if (ret)
return ret; return ret;
return size; return size;