raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

greybus: svc: fix an error handling bug in gb_svc_hello()

Browse Source 
commit 5f8583a3b7 upstream.

Cleanup if gb_svc_queue_deferred_request() fails.

Link: https://lore.kernel.org/r/20220202072016.GA6748@kili
Fixes: ee2f2074fd ("greybus: svc: reconfig APBridgeA-Switch link to handle required load")
Cc: stable@vger.kernel.org      # 4.9
[johan: fix commit summary prefix and rename label ]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220202113347.1288-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter
2022-02-02 12:33:45 +01:00
committed by Greg Kroah-Hartman
parent 9f0cd81174
commit 25cd5872d9
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/greybus/svc.c
View File

@@ -866,8 +866,14 @@ static int gb_svc_hello(struct gb_operation *op)
gb_svc_debugfs_init(svc); gb_svc_debugfs_init(svc);
return gb_svc_queue_deferred_request(op); ret = gb_svc_queue_deferred_request(op);
if (ret)
goto err_remove_debugfs;
return 0;
err_remove_debugfs:
gb_svc_debugfs_exit(svc);
err_unregister_device: err_unregister_device:
gb_svc_watchdog_destroy(svc); gb_svc_watchdog_destroy(svc);
device_del(&svc->dev); device_del(&svc->dev);