raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

drm/vc4: Disable overrun interrupts

Browse Source 
We have a read-modify-write race when updating SCALER_DISPCTRL for
underrun and end-of-frame interrupts.
Ideally it would be fixed via a spinlock or similar, but that will
require a reasonable amount of study to ensure we don't get deadlocks.

The underrun reporting is only for debug, so disable it for now.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
This commit is contained in:
Dave Stevenson
2024-01-24 16:35:11 +00:00
committed by Dom Cobley
parent 85d2515b67
commit 2a9b3fbd5b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/vc4/vc4_crtc.c
View File

@@ -852,7 +852,7 @@ static void vc4_crtc_handle_page_flip(struct vc4_crtc *vc4_crtc)
* the CRTC and encoder already reconfigured, leading to * the CRTC and encoder already reconfigured, leading to
* underruns. This can be seen when reconfiguring the CRTC. * underruns. This can be seen when reconfiguring the CRTC.
*/ */
if (vc4->gen < VC4_GEN_6_C) if (0 && vc4->gen < VC4_GEN_6_C)
vc4_hvs_unmask_underrun(hvs, chan); vc4_hvs_unmask_underrun(hvs, chan);
} }
spin_unlock(&vc4_crtc->irq_lock); spin_unlock(&vc4_crtc->irq_lock);

2
drivers/gpu/drm/vc4/vc4_kms.c
View File

@@ -391,7 +391,7 @@ static void vc4_atomic_commit_tail(struct drm_atomic_state *state)
if (WARN_ON(IS_ERR(new_hvs_state))) if (WARN_ON(IS_ERR(new_hvs_state)))
return; return;
if (vc4->gen < VC4_GEN_6_C) { if (0 && vc4->gen < VC4_GEN_6_C) {
struct drm_crtc_state *new_crtc_state; struct drm_crtc_state *new_crtc_state;
struct drm_crtc *crtc; struct drm_crtc *crtc;
int i; int i;