raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

reset: reset-brcmstb-rescal: Support shared use

Browse Source 
reset_control_reset should not be used with shared reset controllers.
Add support for reset_control_assert and _deassert to get the desired
behaviour and avoid ugly warnings in the kernel log.

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This commit is contained in:
Phil Elwell
2021-09-07 14:49:00 +01:00
committed by Dom Cobley
parent 1174c8fe85
commit 374a190b03
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/reset/reset-brcmstb-rescal.c
View File

@@ -20,6 +20,7 @@ struct brcm_rescal_reset {
struct reset_controller_dev rcdev; struct reset_controller_dev rcdev;
}; };
/* Also doubles a deassert */
static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev, static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
unsigned long id) unsigned long id)
{ {
@@ -52,6 +53,13 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
return 0; return 0;
} }
/* A dummy function - deassert/reset does all the work */
static int brcm_rescal_reset_assert(struct reset_controller_dev *rcdev,
unsigned long id)
{
return 0;
}
static int brcm_rescal_reset_xlate(struct reset_controller_dev *rcdev, static int brcm_rescal_reset_xlate(struct reset_controller_dev *rcdev,
const struct of_phandle_args *reset_spec) const struct of_phandle_args *reset_spec)
{ {
@@ -61,6 +69,8 @@ static int brcm_rescal_reset_xlate(struct reset_controller_dev *rcdev,
static const struct reset_control_ops brcm_rescal_reset_ops = { static const struct reset_control_ops brcm_rescal_reset_ops = {
.reset = brcm_rescal_reset_set, .reset = brcm_rescal_reset_set,
.deassert = brcm_rescal_reset_set,
.assert = brcm_rescal_reset_assert,
}; };
static int brcm_rescal_reset_probe(struct platform_device *pdev) static int brcm_rescal_reset_probe(struct platform_device *pdev)