raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

ssb: sdio: Don't overwrite const buffer if block_write fails

Browse Source 
commit 47ec636f7a upstream.

It doesn't make sense to clobber the const driver-side buffer, if a
write-to-device attempt failed. All other SSB variants (PCI, PCMCIA and SoC)
also don't corrupt the buffer on any failure in block_write.
Therefore, remove this memset from the SDIO variant.

Signed-off-by: Michael Büsch <m@bues.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210515210252.318be2ba@wiggum
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Buesch
2021-05-15 21:02:52 +02:00
committed by Greg Kroah-Hartman
parent 58940e88ba
commit 43189683fe
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/ssb/sdio.c
View File

@@ -411,7 +411,6 @@ static void ssb_sdio_block_write(struct ssb_device *dev, const void *buffer,
sdio_claim_host(bus->host_sdio); sdio_claim_host(bus->host_sdio);
if (unlikely(ssb_sdio_switch_core(bus, dev))) { if (unlikely(ssb_sdio_switch_core(bus, dev))) {
error = -EIO; error = -EIO;
memset((void *)buffer, 0xff, count);
goto err_out; goto err_out;
} }
offset |= bus->sdio_sbaddr & 0xffff; offset |= bus->sdio_sbaddr & 0xffff;