raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

net: bridge: vlan: fix memory leak in __allowed_ingress

Browse Source 
[ Upstream commit fd20d97383 ]

When using per-vlan state, if vlan snooping and stats are disabled,
untagged or priority-tagged ingress frame will go to check pvid state.
If the port state is forwarding and the pvid state is not
learning/forwarding, untagged or priority-tagged frame will be dropped
but skb memory is not freed.
Should free skb when __allowed_ingress returns false.

Fixes: a580c76d53 ("net: bridge: vlan: add per-vlan state")
Signed-off-by: Tim Yi <tim.yi@pica8.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Link: https://lore.kernel.org/r/20220127074953.12632-1-tim.yi@pica8.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Tim Yi
2022-01-27 15:49:53 +08:00
committed by Greg Kroah-Hartman
parent bc58a5bb9e
commit 446ff1fc37
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/bridge/br_vlan.c
View File

@@ -543,10 +543,10 @@ static bool __allowed_ingress(const struct net_bridge *br,
if (!br_opt_get(br, BROPT_VLAN_STATS_ENABLED)) { if (!br_opt_get(br, BROPT_VLAN_STATS_ENABLED)) {
if (*state == BR_STATE_FORWARDING) { if (*state == BR_STATE_FORWARDING) {
*state = br_vlan_get_pvid_state(vg); *state = br_vlan_get_pvid_state(vg);
return br_vlan_state_allowed(*state, true); if (!br_vlan_state_allowed(*state, true))
} else { goto drop;
return true;
} }
return true;
} }
} }
v = br_vlan_find(vg, *vid); v = br_vlan_find(vg, *vid);