raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

lan78xx: Debounce link events to minimize poll storm

Browse Source 
The bInterval is set to 4 (i.e. 8 microframes => 1ms) and the only bit
that the driver pays attention to is "link was reset". If there's a
flapping status bit in that endpoint data, (such as if PHY negotiation
needs a few tries to get a stable link) then polling at a slower rate
would act as a de-bounce.

See: https://github.com/raspberrypi/linux/issues/2447
This commit is contained in:
Joshua Emele
2018-11-07 16:07:40 -08:00
committed by Dom Cobley
parent b1deea0371
commit 4824e4d787
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/usb/lan78xx.c
View File

@@ -605,6 +605,11 @@ static bool enable_tso;
module_param(enable_tso, bool, 0644); module_param(enable_tso, bool, 0644);
MODULE_PARM_DESC(enable_tso, "Enables TCP segmentation offload"); MODULE_PARM_DESC(enable_tso, "Enables TCP segmentation offload");
#define INT_URB_MICROFRAMES_PER_MS 8
static int int_urb_interval_ms = 8;
module_param(int_urb_interval_ms, int, 0);
MODULE_PARM_DESC(int_urb_interval_ms, "Override usb interrupt urb interval");
static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data) static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data)
{ {
u32 *buf; u32 *buf;
@@ -4735,7 +4740,13 @@ static int lan78xx_probe(struct usb_interface *intf,
if (ret < 0) if (ret < 0)
goto out4; goto out4;
if (int_urb_interval_ms <= 0)
period = ep_intr->desc.bInterval; period = ep_intr->desc.bInterval;
else
period = int_urb_interval_ms * INT_URB_MICROFRAMES_PER_MS;
netif_notice(dev, probe, netdev, "int urb period %d\n", period);
maxp = usb_maxpacket(dev->udev, dev->pipe_intr); maxp = usb_maxpacket(dev->udev, dev->pipe_intr);
dev->urb_intr = usb_alloc_urb(0, GFP_KERNEL); dev->urb_intr = usb_alloc_urb(0, GFP_KERNEL);