mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-07 10:29:52 +00:00
reset: bail if try_module_get() fails
Abort instead of returning a new reset control for a reset controller
device that is going to have its module unloaded.
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 61fc413176 ("reset: Add reset controller API")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
@@ -774,7 +774,10 @@ __reset_control_get_internal(struct reset_controller_dev *rcdev,
|
|||||||
if (!rstc)
|
if (!rstc)
|
||||||
return ERR_PTR(-ENOMEM);
|
return ERR_PTR(-ENOMEM);
|
||||||
|
|
||||||
try_module_get(rcdev->owner);
|
if (!try_module_get(rcdev->owner)) {
|
||||||
|
kfree(rstc);
|
||||||
|
return ERR_PTR(-ENODEV);
|
||||||
|
}
|
||||||
|
|
||||||
rstc->rcdev = rcdev;
|
rstc->rcdev = rcdev;
|
||||||
list_add(&rstc->list, &rcdev->reset_control_head);
|
list_add(&rstc->list, &rcdev->reset_control_head);
|
||||||
|
|||||||
Reference in New Issue
Block a user