raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

media: i2c: imx290: Handle exposure correctly when vblank changes

Browse Source 
When vblank changes we must modify the exposure range. Also, with this
sensor, the effective exposure time implicitly changes when vblank
does, so we have to reset it after every vblank update.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
This commit is contained in:
David Plowman
2021-02-18 11:58:29 +00:00
committed by Dom Cobley
parent 96dfc16df5
commit 52d076ea22
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/media/i2c/imx290.c
View File

@@ -618,6 +618,24 @@ static int imx290_set_vmax(struct imx290 *imx290, u32 val)
if (ret) if (ret)
dev_err(imx290->dev, "Unable to write vmax\n"); dev_err(imx290->dev, "Unable to write vmax\n");
/*
* Changing vblank changes the allowed range for exposure.
* We don't supply the current exposure as default here as it
* may lie outside the new range. We will reset it just below.
*/
__v4l2_ctrl_modify_range(imx290->exposure,
IMX290_EXPOSURE_MIN,
vmax - 2,
IMX290_EXPOSURE_STEP,
vmax - 2);
/*
* Becuse of the way exposure works for this sensor, updating
* vblank causes the effective exposure to change, so we must
* set it back to the "new" correct value.
*/
imx290_set_exposure(imx290, imx290->exposure->val);
return ret; return ret;
} }