raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

allo-boss-dac mute output when changing parameters

Browse Source 
Since I noticed that sometimes changing sample rates causes some digital
quirks and noises, I've changed the function to mute the output before
performing the changes and then unmute it when an error occurs or the
parameters got set.

Signed-off-by: Alessandro Marcon <marconalessandro04@gmail.com>
This commit is contained in:
alessandromrc
2024-03-26 23:13:37 +01:00
committed by Dom Cobley
parent 997abe0a01
commit 5eed366cef
1 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
sound/soc/bcm/allo-boss-dac.c
View File

@@ -275,23 +275,34 @@ static int snd_allo_boss_hw_params(
struct snd_soc_pcm_runtime *rtd = substream->private_data;
int channels = params_channels(params);
int width = snd_pcm_format_width(params_format(params));
struct snd_soc_component *component = snd_soc_rtd_to_codec(rtd, 0)->component;
struct snd_soc_card *card = rtd->card;
/* Mute before changing sample rate */
snd_allo_boss_gpio_mute(card);
if (snd_soc_allo_boss_master) {
struct snd_soc_component *component = snd_soc_rtd_to_codec(rtd, 0)->component;
snd_allo_boss_set_sclk(component, params_rate(params));
snd_allo_boss_set_sclk(component,
params_rate(params));
ret = snd_allo_boss_update_rate_den(
substream, params);
ret = snd_allo_boss_update_rate_den(substream, params);
if (ret)
return ret;
goto error;
}
ret = snd_soc_dai_set_bclk_ratio(snd_soc_rtd_to_cpu(rtd, 0), channels * width);
if (ret)
return ret;
goto error;
ret = snd_soc_dai_set_bclk_ratio(snd_soc_rtd_to_codec(rtd, 0), channels * width);
if (ret)
goto error;
/* Unmute after setting parameters or having an error */
error:
snd_allo_boss_gpio_unmute(card);
return ret;
}