raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

net: dql: Avoid calling BUG() when WARN() is enough

Browse Source 
[ Upstream commit 4854b463c4 ]

If the dql_queued() function receives an invalid argument, WARN about it
and continue, instead of crashing the kernel.

This was raised by checkpatch, when I am refactoring this code (see
following patch/commit)

	WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240411192241.2498631-2-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Breno Leitao
2024-04-11 12:22:29 -07:00
committed by Greg Kroah-Hartman
parent 72c181825a
commit 6393ffc888
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/linux/dynamic_queue_limits.h
View File

@@ -91,7 +91,8 @@ static inline void dql_queued(struct dql *dql, unsigned int count)
{ {
unsigned long map, now, now_hi, i; unsigned long map, now, now_hi, i;
BUG_ON(count > DQL_MAX_OBJECT); if (WARN_ON_ONCE(count > DQL_MAX_OBJECT))
return;
dql->last_obj_cnt = count; dql->last_obj_cnt = count;