docs: kdoc: remove dead code

create_parameter_list() tests an argument against the same regex twice, in
two different locations; remove the pointless extra tests and the
never-executed error cases that go with them.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20250814154035.328769-2-corbet@lwn.net
This commit is contained in:
Jonathan Corbet
2025-08-14 09:40:29 -06:00
parent 6cf5f13ef3
commit 670ec7333a

View File

@@ -564,28 +564,18 @@ class KernelDoc:
args.insert(0, first_arg.pop())
dtype = ' '.join(first_arg)
bitfield_re = KernRe(r'(.*?):(\w+)')
for param in args:
if KernRe(r'^(\*+)\s*(.*)').match(param):
r = KernRe(r'^(\*+)\s*(.*)')
if not r.match(param):
self.emit_msg(ln, f"Invalid param: {param}")
continue
param = r.group(1)
r = KernRe(r'^(\*+)\s*(.*)')
if r.match(param):
self.push_parameter(ln, decl_type, r.group(2),
f"{dtype} {r.group(1)}",
arg, declaration_name)
elif KernRe(r'(.*?):(\w+)').search(param):
r = KernRe(r'(.*?):(\w+)')
if not r.match(param):
self.emit_msg(ln, f"Invalid param: {param}")
continue
elif bitfield_re.search(param):
if dtype != "": # Skip unnamed bit-fields
self.push_parameter(ln, decl_type, r.group(1),
f"{dtype}:{r.group(2)}",
self.push_parameter(ln, decl_type, bitfield_re.group(1),
f"{dtype}:{bitfield_re.group(2)}",
arg, declaration_name)
else:
self.push_parameter(ln, decl_type, param, dtype,