raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

drivers: i2c: imx477: Use pm_runtime_use_autosuspend()

Browse Source 
Switch the power management in the imx477 device driver to use auto-
suspend with a 5s timeout.

This improves mode switching time that avoids additional regulator
switch-on delays and common register I2C writes.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This commit is contained in:
Naushir Patuck
2025-11-03 13:30:40 +00:00
committed by Dom Cobley
parent 2618cc99f4
commit 6efb02ee78
1 changed files with 22 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
drivers/media/i2c/imx477.c
View File

@@ -1268,7 +1268,8 @@ static int imx477_set_ctrl(struct v4l2_ctrl *ctrl)
break; break;
} }
pm_runtime_put(&client->dev); pm_runtime_mark_last_busy(&client->dev);
pm_runtime_put_autosuspend(&client->dev);
return ret; return ret;
} }
@@ -1694,22 +1695,23 @@ static int imx477_set_stream(struct v4l2_subdev *sd, int enable)
} }
if (enable) { if (enable) {
ret = pm_runtime_get_sync(&client->dev); ret = pm_runtime_resume_and_get(&client->dev);
if (ret < 0) { if (ret < 0)
pm_runtime_put_noidle(&client->dev);
goto err_unlock; goto err_unlock;
}
/* /*
* Apply default & customized values * Apply default & customized values
* and then start streaming. * and then start streaming.
*/ */
ret = imx477_start_streaming(imx477); ret = imx477_start_streaming(imx477);
if (ret) if (ret) {
goto err_rpm_put; pm_runtime_put_sync(&client->dev);
goto err_unlock;
}
} else { } else {
imx477_stop_streaming(imx477); imx477_stop_streaming(imx477);
pm_runtime_put(&client->dev); pm_runtime_mark_last_busy(&client->dev);
pm_runtime_put_autosuspend(&client->dev);
} }
imx477->streaming = enable; imx477->streaming = enable;
@@ -1722,8 +1724,6 @@ static int imx477_set_stream(struct v4l2_subdev *sd, int enable)
return ret; return ret;
err_rpm_put:
pm_runtime_put(&client->dev);
err_unlock: err_unlock:
mutex_unlock(&imx477->mutex); mutex_unlock(&imx477->mutex);
@@ -2183,10 +2183,16 @@ static int imx477_probe(struct i2c_client *client)
/* Initialize default format */ /* Initialize default format */
imx477_set_default_format(imx477); imx477_set_default_format(imx477);
/* Enable runtime PM and turn off the device */ /*
* Enable runtime PM with 5s autosuspend. As the device has been powered
* manually, mark it as active, and increase the usage count without
* resuming the device.
*/
pm_runtime_set_active(dev); pm_runtime_set_active(dev);
pm_runtime_get_noresume(dev);
pm_runtime_enable(dev); pm_runtime_enable(dev);
pm_runtime_idle(dev); pm_runtime_set_autosuspend_delay(dev, 5000);
pm_runtime_use_autosuspend(dev);
/* This needs the pm runtime to be registered. */ /* This needs the pm runtime to be registered. */
ret = imx477_init_controls(imx477); ret = imx477_init_controls(imx477);
@@ -2215,6 +2221,9 @@ static int imx477_probe(struct i2c_client *client)
goto error_media_entity; goto error_media_entity;
} }
pm_runtime_mark_last_busy(&client->dev);
pm_runtime_put_autosuspend(&client->dev);
return 0; return 0;
error_media_entity: error_media_entity:
@@ -2225,7 +2234,7 @@ error_handler_free:
error_power_off: error_power_off:
pm_runtime_disable(&client->dev); pm_runtime_disable(&client->dev);
pm_runtime_set_suspended(&client->dev); pm_runtime_put_noidle(&client->dev);
imx477_power_off(&client->dev); imx477_power_off(&client->dev);
return ret; return ret;