raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

media: bcm2835-unicam: Drop WARN on uing direct cache alias

Browse Source 
Pi 0&1 pass all ARM accesses through the VPU L2 cache, therefore
the dma-ranges property sets the cache alias bits to other
than the direct alias, hence this WARN was firing.

It was overprotective coding, so assume that everything is OK
with the dma-ranges, and remove the WARN.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
This commit is contained in:
Dave Stevenson
2020-08-27 16:30:26 +01:00
committed by Dom Cobley
parent 36284925d0
commit 7b2643a5c3
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/platform/bcm2835/bcm2835-unicam.c
View File

@@ -709,13 +709,6 @@ static void unicam_wr_dma_addr(struct unicam_device *dev, dma_addr_t dmaaddr,
{
dma_addr_t endaddr = dmaaddr + buffer_size;
/*
* dmaaddr and endaddr should be a 32-bit address with the top two bits
* set to 0x3 to signify uncached access through the Videocore memory
* controller.
*/
WARN_ON((dmaaddr >> 30) != 0x3 || (endaddr >> 30) != 0x3);
if (pad_id == IMAGE_PAD) {
reg_write(dev, UNICAM_IBSA0, dmaaddr);
reg_write(dev, UNICAM_IBEA0, endaddr);