raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

usb: typec: ucsi: Fix busy loop on ASUS VivoBooks

Browse Source 
If the busy indicator is set, all other fields in CCI should be
clear according to the spec. However, some UCSI implementations do
not follow this rule and report bogus data in CCI along with the
busy indicator. Ignore the contents of CCI if the busy indicator is
set.

If a command timeout is hit it is possible that the EVENT_PENDING
bit is cleared while connector work is still scheduled which can
cause the EVENT_PENDING bit to go out of sync with scheduled connector
work. Check and set the EVENT_PENDING bit on entry to
ucsi_handle_connector_change() to fix this.

Finally, check UCSI_CCI_BUSY before the return code of ->sync_control.
This ensures that the command is cancelled even if ->sync_control
returns an error (most likely -ETIMEDOUT).

Reported-by: Anurag Bijea <icaliberdev@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219108
Bisected-by: Christian Heusel <christian@heusel.eu>
Tested-by: Anurag Bijea <icaliberdev@gmail.com>
Fixes: de52aca4d9 ("usb: typec: ucsi: Never send a lone connector change ack")
Cc: stable@vger.kernel.org
Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240912074132.722855-1-lk@c--e.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian A. Ehrhardt
2024-09-12 09:41:32 +02:00
committed by Greg Kroah-Hartman
parent e8afd5ace1
commit 7fa6b25dfb
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/usb/typec/ucsi/ucsi.c
View File

@@ -38,6 +38,10 @@
void ucsi_notify_common(struct ucsi *ucsi, u32 cci) void ucsi_notify_common(struct ucsi *ucsi, u32 cci)
{ {
/* Ignore bogus data in CCI if busy indicator is set. */
if (cci & UCSI_CCI_BUSY)
return;
if (UCSI_CCI_CONNECTOR(cci)) if (UCSI_CCI_CONNECTOR(cci))
ucsi_connector_change(ucsi, UCSI_CCI_CONNECTOR(cci)); ucsi_connector_change(ucsi, UCSI_CCI_CONNECTOR(cci));
@@ -103,15 +107,13 @@ static int ucsi_run_command(struct ucsi *ucsi, u64 command, u32 *cci,
return -EINVAL; return -EINVAL;
ret = ucsi->ops->sync_control(ucsi, command); ret = ucsi->ops->sync_control(ucsi, command);
if (ret) if (ucsi->ops->read_cci(ucsi, cci))
return ret; return -EIO;
ret = ucsi->ops->read_cci(ucsi, cci);
if (ret)
return ret;
if (*cci & UCSI_CCI_BUSY) if (*cci & UCSI_CCI_BUSY)
return ucsi_run_command(ucsi, UCSI_CANCEL, cci, NULL, 0, false) ?: -EBUSY; return ucsi_run_command(ucsi, UCSI_CANCEL, cci, NULL, 0, false) ?: -EBUSY;
if (ret)
return ret;
if (!(*cci & UCSI_CCI_COMMAND_COMPLETE)) if (!(*cci & UCSI_CCI_COMMAND_COMPLETE))
return -EIO; return -EIO;
@@ -1197,6 +1199,10 @@ static void ucsi_handle_connector_change(struct work_struct *work)
mutex_lock(&con->lock); mutex_lock(&con->lock);
if (!test_and_set_bit(EVENT_PENDING, &ucsi->flags))
dev_err_once(ucsi->dev, "%s entered without EVENT_PENDING\n",
__func__);
command = UCSI_GET_CONNECTOR_STATUS | UCSI_CONNECTOR_NUMBER(con->num); command = UCSI_GET_CONNECTOR_STATUS | UCSI_CONNECTOR_NUMBER(con->num);
ret = ucsi_send_command_common(ucsi, command, &con->status, ret = ucsi_send_command_common(ucsi, command, &con->status,