raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

media: dw9807-vcm: Smooth the first user movement of the lens

Browse Source 
The power up/down sequence is already ramped. Extend this to
the first user movement as well, as this will generally avoid
the "tick" noises due to rapid movements and overshooting.
Subsequent movements are generally smaller and so don't cause
issues.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
This commit is contained in:
Dave Stevenson
2023-01-03 16:53:37 +00:00
committed by Dom Cobley
parent d3890b856a
commit 846e000a7e
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/i2c/dw9807-vcm.c
View File

@@ -62,6 +62,7 @@ struct dw9807_device {
u16 idle_pos;
struct regulator *vdd;
struct notifier_block notifier;
bool first;
};
static inline struct dw9807_device *sd_to_dw9807_vcm(
@@ -176,6 +177,8 @@ static int dw9807_active(struct dw9807_device *dw9807_dev)
return ret;
}
dw9807_dev->first = true;
return dw9807_ramp(client, dw9807_dev->idle_pos, dw9807_dev->current_val);
}
@@ -230,9 +233,11 @@ static int dw9807_set_ctrl(struct v4l2_ctrl *ctrl)
if (ctrl->id == V4L2_CID_FOCUS_ABSOLUTE) {
struct i2c_client *client = v4l2_get_subdevdata(&dev_vcm->sd);
int start = (dev_vcm->first) ? dev_vcm->current_val : ctrl->val;
dev_vcm->first = false;
dev_vcm->current_val = ctrl->val;
return dw9807_ramp(client, ctrl->val, ctrl->val);
return dw9807_ramp(client, start, ctrl->val);
}
return -EINVAL;