raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

net: lan78xx: Ack pending PHY ints when resetting

Browse Source 
lan78xx_link_reset explicitly clears the MAC's view of the PHY's IRQ
status. In doing so it potentially leaves the PHY with a pending
interrupt that will never be acknowledged, at which point no further
interrupts will be generated.

Avoid the problem by acknowledging any pending PHY interrupt after
clearing the MAC's status bit.

See: https://github.com/raspberrypi/linux/issues/2937

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This commit is contained in:
Phil Elwell
2020-12-15 16:38:37 +00:00
committed by Dom Cobley
parent 81551459bd
commit 85d123c80b
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/usb/lan78xx.c
View File

@@ -1629,7 +1629,16 @@ exit_unlock:
*/ */
static int lan78xx_phy_int_ack(struct lan78xx_net *dev) static int lan78xx_phy_int_ack(struct lan78xx_net *dev)
{ {
return lan78xx_write_reg(dev, INT_STS, INT_STS_PHY_INT_); struct phy_device *phydev = dev->net->phydev;
int ret = lan78xx_write_reg(dev, INT_STS, INT_STS_PHY_INT_);
if (unlikely(ret < 0))
return ret;
/* Acknowledge any pending PHY interrupt, lest it be the last */
phy_read(phydev, LAN88XX_INT_STS);
return 0;
} }
/* some work can't be done in tasklets, so we use keventd /* some work can't be done in tasklets, so we use keventd