raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

thermal/drivers/qoriq: Only enable supported sensors

Browse Source 
There are MAX 16 sensors, but not all of them supported. Such as
i.MX8MQ, there are only 3 sensors. Enabling all 16 sensors will
touch reserved bits from i.MX8MQ reference mannual, and TMU will stuck,
temperature will not update anymore.

Fixes: 45038e03d6 ("thermal: qoriq: Enable all sensors before registering them")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230516083746.63436-3-peng.fan@oss.nxp.com
This commit is contained in:
Peng Fan
2023-05-16 16:37:45 +08:00
committed by Daniel Lezcano
parent 5474e98b3e
commit 9301575df2
1 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/thermal/qoriq_thermal.c
View File

@@ -31,7 +31,6 @@
#define TMR_DISABLE 0x0 #define TMR_DISABLE 0x0
#define TMR_ME 0x80000000 #define TMR_ME 0x80000000
#define TMR_ALPF 0x0c000000 #define TMR_ALPF 0x0c000000
#define TMR_MSITE_ALL GENMASK(15, 0)
#define REGS_TMTMIR 0x008 /* Temperature measurement interval Register */ #define REGS_TMTMIR 0x008 /* Temperature measurement interval Register */
#define TMTMIR_DEFAULT 0x0000000f #define TMTMIR_DEFAULT 0x0000000f
@@ -105,6 +104,11 @@ static int tmu_get_temp(struct thermal_zone_device *tz, int *temp)
* within sensor range. TEMP is an 9 bit value representing * within sensor range. TEMP is an 9 bit value representing
* temperature in KelVin. * temperature in KelVin.
*/ */
regmap_read(qdata->regmap, REGS_TMR, &val);
if (!(val & TMR_ME))
return -EAGAIN;
if (regmap_read_poll_timeout(qdata->regmap, if (regmap_read_poll_timeout(qdata->regmap,
REGS_TRITSR(qsensor->id), REGS_TRITSR(qsensor->id),
val, val,
@@ -128,15 +132,7 @@ static const struct thermal_zone_device_ops tmu_tz_ops = {
static int qoriq_tmu_register_tmu_zone(struct device *dev, static int qoriq_tmu_register_tmu_zone(struct device *dev,
struct qoriq_tmu_data *qdata) struct qoriq_tmu_data *qdata)
{ {
int id; int id, sites = 0;
if (qdata->ver == TMU_VER1) {
regmap_write(qdata->regmap, REGS_TMR,
TMR_MSITE_ALL | TMR_ME | TMR_ALPF);
} else {
regmap_write(qdata->regmap, REGS_V2_TMSR, TMR_MSITE_ALL);
regmap_write(qdata->regmap, REGS_TMR, TMR_ME | TMR_ALPF_V2);
}
for (id = 0; id < SITES_MAX; id++) { for (id = 0; id < SITES_MAX; id++) {
struct thermal_zone_device *tzd; struct thermal_zone_device *tzd;
@@ -153,14 +149,26 @@ static int qoriq_tmu_register_tmu_zone(struct device *dev,
if (ret == -ENODEV) if (ret == -ENODEV)
continue; continue;
regmap_write(qdata->regmap, REGS_TMR, TMR_DISABLE);
return ret; return ret;
} }
if (qdata->ver == TMU_VER1)
sites |= 0x1 << (15 - id);
else
sites |= 0x1 << id;
if (devm_thermal_add_hwmon_sysfs(dev, tzd)) if (devm_thermal_add_hwmon_sysfs(dev, tzd))
dev_warn(dev, dev_warn(dev,
"Failed to add hwmon sysfs attributes\n"); "Failed to add hwmon sysfs attributes\n");
}
if (sites) {
if (qdata->ver == TMU_VER1) {
regmap_write(qdata->regmap, REGS_TMR, TMR_ME | TMR_ALPF | sites);
} else {
regmap_write(qdata->regmap, REGS_V2_TMSR, sites);
regmap_write(qdata->regmap, REGS_TMR, TMR_ME | TMR_ALPF_V2);
}
} }
return 0; return 0;