raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-13 13:30:08 +00:00
Code Issues Projects Releases Wiki Activity

dmaengine: zynqmp_dma: fix lockdep warning in tasklet

Browse Source 
The tasklet that handles the completed dma transfers uses spin_unlock
for unlocking a spin lock that was previously locked with
spin_lock_irqsave.

This caused the following lockdep warning about an inconsistent lock
state:

	inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.

We must use spin_lock_irqsave, because it is possible to queue DMA
transfers from an irq handler.

Replace the spin_unlock and spin_lock by spin_unlock_irqrestore and
spin_lock_irqsave.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Link: https://lore.kernel.org/r/20210826094742.1302009-8-m.tretter@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Michael Tretter
2021-08-26 11:47:42 +02:00
committed by Vinod Koul
parent 193a750df5
commit 9558cf4ad0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/xilinx/zynqmp_dma.c
View File

@@ -611,9 +611,9 @@ static void zynqmp_dma_chan_desc_cleanup(struct zynqmp_dma_chan *chan)
callback = desc->async_tx.callback; callback = desc->async_tx.callback;
callback_param = desc->async_tx.callback_param; callback_param = desc->async_tx.callback_param;
if (callback) { if (callback) {
spin_unlock(&chan->lock); spin_unlock_irqrestore(&chan->lock, irqflags);
callback(callback_param); callback(callback_param);
spin_lock(&chan->lock); spin_lock_irqsave(&chan->lock, irqflags);
} }
/* Run any dependencies, then free the descriptor */ /* Run any dependencies, then free the descriptor */