raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

of: unittest: Fix device reference count leak in of_unittest_pci_node_verify

Browse Source 
In of_unittest_pci_node_verify(), when the add parameter is false,
device_find_any_child() obtains a reference to a child device. This
function implicitly calls get_device() to increment the device's
reference count before returning the pointer. However, the caller
fails to properly release this reference by calling put_device(),
leading to a device reference count leak. Add put_device() in the else
branch immediately after child_dev is no longer needed.

As the comment of device_find_any_child states: "NOTE: you will need
to drop the reference with put_device() after use".

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 26409dd045 ("of: unittest: Add pci_dt_testdrv pci driver")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
This commit is contained in:
Ma Ke
2025-09-30 16:16:18 +08:00
committed by Rob Herring (Arm)
parent 4e66293bb1
commit a8de554774
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/of/unittest.c
View File

@@ -4300,6 +4300,7 @@ static int of_unittest_pci_node_verify(struct pci_dev *pdev, bool add)
unittest(!np, "Child device tree node is not removed\n"); unittest(!np, "Child device tree node is not removed\n");
child_dev = device_find_any_child(&pdev->dev); child_dev = device_find_any_child(&pdev->dev);
unittest(!child_dev, "Child device is not removed\n"); unittest(!child_dev, "Child device is not removed\n");
put_device(child_dev);
} }
failed: failed: