raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

media: i2c: imx296: Get sensor crop working

Browse Source 
Add a missing register write (MIPIC_AREA3W) when setting up a crop
window in the sensor to get this functionality working.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This commit is contained in:
Naushir Patuck
2023-03-14 10:10:01 +00:00
committed by Dom Cobley
parent b642c5f9cf
commit aa56c6d7bd
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/i2c/imx296.c
View File

@@ -175,6 +175,7 @@ MODULE_PARM_DESC(trigger_mode, "Set trigger mode: 0=default, 1=XTRIG");
#define IMX296_CKREQSEL IMX296_REG_8BIT(0x4101) #define IMX296_CKREQSEL IMX296_REG_8BIT(0x4101)
#define IMX296_CKREQSEL_HS BIT(2) #define IMX296_CKREQSEL_HS BIT(2)
#define IMX296_GTTABLENUM IMX296_REG_8BIT(0x4114) #define IMX296_GTTABLENUM IMX296_REG_8BIT(0x4114)
#define IMX296_MIPIC_AREA3W IMX296_REG_16BIT(0x4182)
#define IMX296_CTRL418C IMX296_REG_8BIT(0x418c) #define IMX296_CTRL418C IMX296_REG_8BIT(0x418c)
struct imx296_clk_params { struct imx296_clk_params {
@@ -530,8 +531,11 @@ static int imx296_setup(struct imx296 *sensor, struct v4l2_subdev_state *state)
imx296_write(sensor, IMX296_FID0_ROIPV1, crop->top, &ret); imx296_write(sensor, IMX296_FID0_ROIPV1, crop->top, &ret);
imx296_write(sensor, IMX296_FID0_ROIWH1, crop->width, &ret); imx296_write(sensor, IMX296_FID0_ROIWH1, crop->width, &ret);
imx296_write(sensor, IMX296_FID0_ROIWV1, crop->height, &ret); imx296_write(sensor, IMX296_FID0_ROIWV1, crop->height, &ret);
imx296_write(sensor, IMX296_MIPIC_AREA3W, crop->height, &ret);
} else { } else {
imx296_write(sensor, IMX296_FID0_ROI, 0, &ret); imx296_write(sensor, IMX296_FID0_ROI, 0, &ret);
imx296_write(sensor, IMX296_MIPIC_AREA3W,
IMX296_PIXEL_ARRAY_HEIGHT, &ret);
} }
imx296_write(sensor, IMX296_CTRL0D, imx296_write(sensor, IMX296_CTRL0D,