mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 10:00:17 +00:00
gpiolib: Don't prevent IRQ usage of output GPIOs
Upstream Linux deems using output GPIOs to generate IRQs as a bogus use case, even though the BCM2835 GPIO controller is capable of doing so. A number of users would like to make use of this facility, so disable the checks. See: https://github.com/raspberrypi/linux/issues/2527 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
This commit is contained in:
@@ -51,6 +51,8 @@
|
|||||||
* GPIOs can sometimes cost only an instruction or two per bit.
|
* GPIOs can sometimes cost only an instruction or two per bit.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
#define dont_test_bit(b,d) (0)
|
||||||
|
|
||||||
/* Device and char device-related information */
|
/* Device and char device-related information */
|
||||||
static DEFINE_IDA(gpio_ida);
|
static DEFINE_IDA(gpio_ida);
|
||||||
static dev_t gpio_devt;
|
static dev_t gpio_devt;
|
||||||
@@ -3027,8 +3029,8 @@ int gpiod_direction_output_nonotify(struct gpio_desc *desc, int value)
|
|||||||
value = !!value;
|
value = !!value;
|
||||||
|
|
||||||
/* GPIOs used for enabled IRQs shall not be set as output */
|
/* GPIOs used for enabled IRQs shall not be set as output */
|
||||||
if (test_bit(GPIOD_FLAG_USED_AS_IRQ, &flags) &&
|
if (dont_test_bit(GPIOD_FLAG_USED_AS_IRQ, &flags) &&
|
||||||
test_bit(GPIOD_FLAG_IRQ_IS_ENABLED, &flags)) {
|
dont_test_bit(GPIOD_FLAG_IRQ_IS_ENABLED, &flags)) {
|
||||||
gpiod_err(desc,
|
gpiod_err(desc,
|
||||||
"%s: tried to set a GPIO tied to an IRQ as output\n",
|
"%s: tried to set a GPIO tied to an IRQ as output\n",
|
||||||
__func__);
|
__func__);
|
||||||
@@ -4063,8 +4065,8 @@ int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset)
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* To be valid for IRQ the line needs to be input or open drain */
|
/* To be valid for IRQ the line needs to be input or open drain */
|
||||||
if (test_bit(GPIOD_FLAG_IS_OUT, &desc->flags) &&
|
if (dont_test_bit(GPIOD_FLAG_IS_OUT, &desc->flags) &&
|
||||||
!test_bit(GPIOD_FLAG_OPEN_DRAIN, &desc->flags)) {
|
!dont_test_bit(GPIOD_FLAG_OPEN_DRAIN, &desc->flags)) {
|
||||||
chip_err(gc,
|
chip_err(gc,
|
||||||
"%s: tried to flag a GPIO set as output for IRQ\n",
|
"%s: tried to flag a GPIO set as output for IRQ\n",
|
||||||
__func__);
|
__func__);
|
||||||
|
|||||||
Reference in New Issue
Block a user