raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

usb: typec: tipd: Remove WARN_ON in tps6598x_block_read

Browse Source 
Calling tps6598x_block_read with a higher than allowed len can be
handled by just returning an error. There's no need to crash systems
with panic-on-warn enabled.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Sven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20210914140235.65955-3-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sven Peter
2021-09-14 16:02:35 +02:00
committed by Greg Kroah-Hartman
parent ac588dfa66
commit b7a0a63f3f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/typec/tipd/core.c
View File

@@ -117,7 +117,7 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
u8 data[TPS_MAX_LEN + 1]; u8 data[TPS_MAX_LEN + 1];
int ret; int ret;
if (WARN_ON(len + 1 > sizeof(data))) if (len + 1 > sizeof(data))
return -EINVAL; return -EINVAL;
if (!tps->i2c_protocol) if (!tps->i2c_protocol)