raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

media: i2c: imx290: Drop imx290_write_buffered_reg()

Browse Source 
The imx290_write_buffered_reg() function wraps a register write with
register hold, to enable changing multiple registers synchronously. It
is used for the gain only, which is an 8-bit register, defeating its
purpose.

The feature is useful, but should be implemented differently. Drop the
function for now, to prepare for a rework of register access.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
This commit is contained in:
Laurent Pinchart
2022-10-16 09:15:08 +03:00
committed by Sakari Ailus
parent 2548df538c
commit b817888a0c
1 changed files with 1 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/media/i2c/imx290.c
View File

@@ -413,41 +413,11 @@ static int imx290_set_register_array(struct imx290 *imx290,
return 0;
}
static int imx290_write_buffered_reg(struct imx290 *imx290, u16 address_low,
u8 nr_regs, u32 value)
{
unsigned int i;
int ret;
ret = imx290_write_reg(imx290, IMX290_REGHOLD, 0x01);
if (ret) {
dev_err(imx290->dev, "Error setting hold register\n");
return ret;
}
for (i = 0; i < nr_regs; i++) {
ret = imx290_write_reg(imx290, address_low + i,
(u8)(value >> (i * 8)));
if (ret) {
dev_err(imx290->dev, "Error writing buffered registers\n");
return ret;
}
}
ret = imx290_write_reg(imx290, IMX290_REGHOLD, 0x00);
if (ret) {
dev_err(imx290->dev, "Error setting hold register\n");
return ret;
}
return ret;
}
static int imx290_set_gain(struct imx290 *imx290, u32 value)
{
int ret;
ret = imx290_write_buffered_reg(imx290, IMX290_GAIN, 1, value);
ret = imx290_write_reg(imx290, IMX290_GAIN, value);
if (ret)
dev_err(imx290->dev, "Unable to write gain\n");