mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 01:49:46 +00:00
phonet: refcount leak in pep_sock_accep
sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not invoked in subsequent failure branches(pep_accept_conn() != 0). Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
committed by
Jakub Kicinski
parent
ab443c5391
commit
bcd0f93353
@@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,
|
|||||||
|
|
||||||
err = pep_accept_conn(newsk, skb);
|
err = pep_accept_conn(newsk, skb);
|
||||||
if (err) {
|
if (err) {
|
||||||
|
__sock_put(sk);
|
||||||
sock_put(newsk);
|
sock_put(newsk);
|
||||||
newsk = NULL;
|
newsk = NULL;
|
||||||
goto drop;
|
goto drop;
|
||||||
|
|||||||
Reference in New Issue
Block a user