raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()

Browse Source 
[ Upstream commit e642197562 ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fixes: 9d7cffaf99 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
Acked-by: David Rivshin <drivshin@allworx.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiapeng Chong
2021-06-01 19:09:03 +08:00
committed by Greg Kroah-Hartman
parent d4abb6e141
commit c391728c9b
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/leds/leds-is31fl32xx.c
View File

@@ -385,6 +385,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
dev_err(dev, dev_err(dev,
"Node %pOF 'reg' conflicts with another LED\n", "Node %pOF 'reg' conflicts with another LED\n",
child); child);
ret = -EINVAL;
goto err; goto err;
} }