raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()

Browse Source 
[ Upstream commit a1e4470823 ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a0023 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiapeng Chong
2021-08-13 14:40:42 +08:00
committed by Greg Kroah-Hartman
parent 5c6bfde245
commit c6ecdcba9d
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/fpga/machxo2-spi.c
View File

@@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
break; break;
if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) { if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
machxo2_cleanup(mgr); machxo2_cleanup(mgr);
ret = -EINVAL;
goto fail; goto fail;
} }
} while (1); } while (1);