raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-07 10:29:52 +00:00
Code Issues Projects Releases Wiki Activity

staging: mt7621-pinctrl: fix uninitialized variable ngroups

Browse Source 
Currently the for_each_node_with_property loop us incrementing variable
ngroups however it was not initialized and hence will contain garbage.
Fix this by initializing ngroups to zero.

Detected with static analysis with cppcheck:

drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:89]: (error) Uninitialized
variable: ngroups

Fixes: e12a1a6e08 ("staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King
2018-11-10 23:28:06 +00:00
committed by Greg Kroah-Hartman
parent 8561fb31a1
commit cd56a51413
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
View File

@@ -82,7 +82,7 @@ static int rt2880_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrldev,
struct property *prop; struct property *prop;
const char *function_name, *group_name; const char *function_name, *group_name;
int ret; int ret;
int ngroups; int ngroups = 0;
unsigned int reserved_maps = 0; unsigned int reserved_maps = 0;
for_each_node_with_property(np_config, "group") for_each_node_with_property(np_config, "group")