raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 10:00:17 +00:00
Code Issues Projects Releases Wiki Activity

net: genet: enable link energy detect powerdown for external PHYs

Browse Source 
There are several warts surrounding bcmgenet_mii_probe() as this
function is called from ndo_open, but it's calling registration-type
functions. The probe should be called at probe time and refactored
such that the PHY device data can be extracted to limit the scope
of this flag to Broadcom PHYs.

For now, pass this flag in as it puts our attached PHY into a low-power
state when disconnected.

Signed-off-by: Jonathan Bell <jonathan@raspberrypi.org>
This commit is contained in:
Jonathan Bell
2019-05-14 17:17:59 +01:00
committed by Dom Cobley
parent 3faac3c3f7
commit d4d5de576f
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/broadcom/genet/bcmmii.c
View File

@@ -317,6 +317,8 @@ int bcmgenet_mii_probe(struct net_device *dev)
/* Communicate the integrated PHY revision */ /* Communicate the integrated PHY revision */
if (priv->internal_phy) if (priv->internal_phy)
phy_flags = priv->gphy_rev; phy_flags = priv->gphy_rev;
else
phy_flags = PHY_BRCM_AUTO_PWRDWN_ENABLE;
/* This is an ugly quirk but we have not been correctly interpreting /* This is an ugly quirk but we have not been correctly interpreting
* the phy_interface values and we have done that across different * the phy_interface values and we have done that across different