raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

drm/bridge: tpd12s015: Drop buggy __exit annotation for remove function

Browse Source 
[ Upstream commit ce3e112e7a ]

With tpd12s015_remove() marked with __exit this function is discarded
when the driver is compiled as a built-in. The result is that when the
driver unbinds there is no cleanup done which results in resource
leakage or worse.

Fixes: cff5e6f7e8 ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-19-u.kleine-koenig@pengutronix.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Uwe Kleine-König
2023-11-02 17:56:42 +01:00
committed by Greg Kroah-Hartman
parent a417515e57
commit e00ec59019
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/bridge/ti-tpd12s015.c
View File

@@ -179,7 +179,7 @@ static int tpd12s015_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int __exit tpd12s015_remove(struct platform_device *pdev) static int tpd12s015_remove(struct platform_device *pdev)
{ {
struct tpd12s015_device *tpd = platform_get_drvdata(pdev); struct tpd12s015_device *tpd = platform_get_drvdata(pdev);
@@ -197,7 +197,7 @@ MODULE_DEVICE_TABLE(of, tpd12s015_of_match);
static struct platform_driver tpd12s015_driver = { static struct platform_driver tpd12s015_driver = {
.probe = tpd12s015_probe, .probe = tpd12s015_probe,
.remove = __exit_p(tpd12s015_remove), .remove = tpd12s015_remove,
.driver = { .driver = {
.name = "tpd12s015", .name = "tpd12s015",
.of_match_table = tpd12s015_of_match, .of_match_table = tpd12s015_of_match,