raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

serial: amba-pl011: prefer dma_mapping_error() over explicit address checking

Browse Source 
Check for returned DMA addresses using specialized dma_mapping_error()
helper which is generally recommended for this purpose by
Documentation/core-api/dma-api.rst:

  "In some circumstances dma_map_single(), ...
will fail to create a mapping. A driver can check for these errors
by testing the returned DMA address with dma_mapping_error()."

Found via static analysis and this is similar to commit fa0308134d
("ALSA: memalloc: prefer dma_mapping_error() over explicit address checking")

Fixes: 58ac1b3799 ("ARM: PL011: Fix DMA support")
Cc: stable <stable@kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link: https://patch.msgid.link/20251027092053.87937-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Miaoqian Lin
2025-10-27 17:20:50 +08:00
committed by Greg Kroah-Hartman
parent dcb6fa37fd
commit eb4917f557
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/amba-pl011.c
View File

@@ -628,7 +628,7 @@ static int pl011_dma_tx_refill(struct uart_amba_port *uap)
dmatx->len = count; dmatx->len = count;
dmatx->dma = dma_map_single(dma_dev->dev, dmatx->buf, count, dmatx->dma = dma_map_single(dma_dev->dev, dmatx->buf, count,
DMA_TO_DEVICE); DMA_TO_DEVICE);
if (dmatx->dma == DMA_MAPPING_ERROR) { if (dma_mapping_error(dma_dev->dev, dmatx->dma)) {
uap->dmatx.queued = false; uap->dmatx.queued = false;
dev_dbg(uap->port.dev, "unable to map TX DMA\n"); dev_dbg(uap->port.dev, "unable to map TX DMA\n");
return -EBUSY; return -EBUSY;