mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 10:00:17 +00:00
drm/amd/display: hpd rx irq not working with eDP interface
[Why] This is the fix for the defect of commitab144f0b4a("drm/amd/display: Allow individual control of eDP hotplug support"). [How] To revise the default eDP hotplug setting and use the enum to git rid of the magic number for different options. Fixes:ab144f0b4a("drm/amd/display: Allow individual control of eDP hotplug support") Cc: stable@vger.kernel.org Cc: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Wenjing Liu <Wenjing.Liu@amd.com> Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com> Signed-off-by: Robin Chen <robin.chen@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
@@ -1080,4 +1080,11 @@ struct dc_dpia_bw_alloc {
|
|||||||
};
|
};
|
||||||
|
|
||||||
#define MAX_SINKS_PER_LINK 4
|
#define MAX_SINKS_PER_LINK 4
|
||||||
|
|
||||||
|
enum dc_hpd_enable_select {
|
||||||
|
HPD_EN_FOR_ALL_EDP = 0,
|
||||||
|
HPD_EN_FOR_PRIMARY_EDP_ONLY,
|
||||||
|
HPD_EN_FOR_SECONDARY_EDP_ONLY,
|
||||||
|
};
|
||||||
|
|
||||||
#endif /* DC_TYPES_H_ */
|
#endif /* DC_TYPES_H_ */
|
||||||
|
|||||||
@@ -528,14 +528,18 @@ static bool construct_phy(struct dc_link *link,
|
|||||||
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
||||||
|
|
||||||
switch (link->dc->config.allow_edp_hotplug_detection) {
|
switch (link->dc->config.allow_edp_hotplug_detection) {
|
||||||
case 1: // only the 1st eDP handles hotplug
|
case HPD_EN_FOR_ALL_EDP:
|
||||||
|
link->irq_source_hpd_rx =
|
||||||
|
dal_irq_get_rx_source(link->hpd_gpio);
|
||||||
|
break;
|
||||||
|
case HPD_EN_FOR_PRIMARY_EDP_ONLY:
|
||||||
if (link->link_index == 0)
|
if (link->link_index == 0)
|
||||||
link->irq_source_hpd_rx =
|
link->irq_source_hpd_rx =
|
||||||
dal_irq_get_rx_source(link->hpd_gpio);
|
dal_irq_get_rx_source(link->hpd_gpio);
|
||||||
else
|
else
|
||||||
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
||||||
break;
|
break;
|
||||||
case 2: // only the 2nd eDP handles hotplug
|
case HPD_EN_FOR_SECONDARY_EDP_ONLY:
|
||||||
if (link->link_index == 1)
|
if (link->link_index == 1)
|
||||||
link->irq_source_hpd_rx =
|
link->irq_source_hpd_rx =
|
||||||
dal_irq_get_rx_source(link->hpd_gpio);
|
dal_irq_get_rx_source(link->hpd_gpio);
|
||||||
@@ -543,6 +547,7 @@ static bool construct_phy(struct dc_link *link,
|
|||||||
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
|
link->irq_source_hpd = DC_IRQ_SOURCE_INVALID;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user