raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 18:09:56 +00:00
Code Issues Projects Releases Wiki Activity

ext4: refactor out ext4_generic_attr_store()

Browse Source 
Refactor out the function ext4_generic_attr_store() to handle the setting
of values of various common types, with no functional changes.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240319113325.3110393-3-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Baokun Li
2024-03-19 19:33:18 +08:00
committed by Theodore Ts'o
parent 9e8e819f8f
commit f536808adc
1 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
fs/ext4/sysfs.c
View File

@@ -443,24 +443,20 @@ static ssize_t ext4_attr_show(struct kobject *kobj,
return 0; return 0;
} }
static ssize_t ext4_attr_store(struct kobject *kobj, static ssize_t ext4_generic_attr_store(struct ext4_attr *a,
struct attribute *attr, struct ext4_sb_info *sbi,
const char *buf, size_t len) const char *buf, size_t len)
{ {
struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info, int ret;
s_kobj);
struct ext4_attr *a = container_of(attr, struct ext4_attr, attr);
void *ptr = calc_ptr(a, sbi);
unsigned int t; unsigned int t;
unsigned long lt; unsigned long lt;
int ret; void *ptr = calc_ptr(a, sbi);
switch (a->attr_id) {
case attr_reserved_clusters:
return reserved_clusters_store(sbi, buf, len);
case attr_pointer_ui:
if (!ptr) if (!ptr)
return 0; return 0;
switch (a->attr_id) {
case attr_pointer_ui:
ret = kstrtouint(skip_spaces(buf), 0, &t); ret = kstrtouint(skip_spaces(buf), 0, &t);
if (ret) if (ret)
return ret; return ret;
@@ -470,19 +466,33 @@ static ssize_t ext4_attr_store(struct kobject *kobj,
*((unsigned int *) ptr) = t; *((unsigned int *) ptr) = t;
return len; return len;
case attr_pointer_ul: case attr_pointer_ul:
if (!ptr)
return 0;
ret = kstrtoul(skip_spaces(buf), 0, &lt); ret = kstrtoul(skip_spaces(buf), 0, &lt);
if (ret) if (ret)
return ret; return ret;
*((unsigned long *) ptr) = lt; *((unsigned long *) ptr) = lt;
return len; return len;
}
return 0;
}
static ssize_t ext4_attr_store(struct kobject *kobj,
struct attribute *attr,
const char *buf, size_t len)
{
struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info,
s_kobj);
struct ext4_attr *a = container_of(attr, struct ext4_attr, attr);
switch (a->attr_id) {
case attr_reserved_clusters:
return reserved_clusters_store(sbi, buf, len);
case attr_inode_readahead: case attr_inode_readahead:
return inode_readahead_blks_store(sbi, buf, len); return inode_readahead_blks_store(sbi, buf, len);
case attr_trigger_test_error: case attr_trigger_test_error:
return trigger_test_error(sbi, buf, len); return trigger_test_error(sbi, buf, len);
default:
return ext4_generic_attr_store(a, sbi, buf, len);
} }
return 0;
} }
static void ext4_sb_release(struct kobject *kobj) static void ext4_sb_release(struct kobject *kobj)