mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-20 16:52:28 +00:00
locking/mutex: Introduce devm_mutex_init()
[ Upstream commit4cd47222e4] Using of devm API leads to a certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release order. Mutex is one of such objects that often is bound to other resources and has no own devm wrapping. Since mutex_destroy() actually does nothing in non-debug builds frequently calling mutex_destroy() is just ignored which is safe for now but wrong formally and can lead to a problem if mutex_destroy() will be extended so introduce devm_mutex_init(). Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu> Signed-off-by: George Stark <gnstark@salutedevices.com> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Marek Behún <kabel@kernel.org> Acked-by: Waiman Long <longman@redhat.com> Link: https://lore.kernel.org/r/20240411161032.609544-2-gnstark@salutedevices.com Signed-off-by: Lee Jones <lee@kernel.org> Stable-dep-of:efc347b9ef("leds: mlxreg: Use devm_mutex_init() for mutex initialization") Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
d30481b7c1
commit
f6828e413f
@@ -12,6 +12,7 @@
|
||||
*/
|
||||
#include <linux/mutex.h>
|
||||
#include <linux/delay.h>
|
||||
#include <linux/device.h>
|
||||
#include <linux/export.h>
|
||||
#include <linux/poison.h>
|
||||
#include <linux/sched.h>
|
||||
@@ -89,6 +90,17 @@ void debug_mutex_init(struct mutex *lock, const char *name,
|
||||
lock->magic = lock;
|
||||
}
|
||||
|
||||
static void devm_mutex_release(void *res)
|
||||
{
|
||||
mutex_destroy(res);
|
||||
}
|
||||
|
||||
int __devm_mutex_init(struct device *dev, struct mutex *lock)
|
||||
{
|
||||
return devm_add_action_or_reset(dev, devm_mutex_release, lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(__devm_mutex_init);
|
||||
|
||||
/***
|
||||
* mutex_destroy - mark a mutex unusable
|
||||
* @lock: the mutex to be destroyed
|
||||
|
||||
Reference in New Issue
Block a user