raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2026-01-04 18:27:36 +00:00
Code Issues Projects Releases Wiki Activity

PM / devfreq: mtk-cci: Fix potential error pointer dereference in probe()

Browse Source 
The drv->sram_reg pointer could be set to ERR_PTR(-EPROBE_DEFER) which
would lead to a error pointer dereference.  Use IS_ERR_OR_NULL() to check
that the pointer is valid.

Fixes: e09bd5757b ("PM / devfreq: mtk-cci: Handle sram regulator probe deferral")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://patchwork.kernel.org/project/linux-pm/patch/aJTNHz8kk8s6Q2os@stanley.mountain/
This commit is contained in:
Dan Carpenter
2025-08-07 18:58:23 +03:00
committed by Chanwoo Choi
parent 1b237f190e
commit fc33bf0e09
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/devfreq/mtk-cci-devfreq.c
View File

@@ -386,7 +386,8 @@ out_disable_cci_clk:
out_free_resources: out_free_resources:
if (regulator_is_enabled(drv->proc_reg)) if (regulator_is_enabled(drv->proc_reg))
regulator_disable(drv->proc_reg); regulator_disable(drv->proc_reg);
if (drv->sram_reg && regulator_is_enabled(drv->sram_reg)) if (!IS_ERR_OR_NULL(drv->sram_reg) &&
regulator_is_enabled(drv->sram_reg))
regulator_disable(drv->sram_reg); regulator_disable(drv->sram_reg);
return ret; return ret;