raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-24 02:52:38 +00:00
Code Issues Projects Releases Wiki Activity

perf annotate: Pass hist_entry to annotate functions

Browse Source 
It's a prepartion to support code annotation and data type
annotation at the same time.  Data type annotation needs more
information in the hist_entry so it needs to be passed deeper.

Also rename a function with the same name in the builtin-annotate.c
to hist_entry__stdio_annotate since it matches better to the command
line option.  And change the condition inside to be simpler.

Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250310224925.799005-5-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
Namhyung Kim
2025-03-10 15:49:22 -07:00
parent 9aa3cbbffb
commit fe8da6692a
4 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/perf/util/annotate.c
View File

@@ -1174,8 +1174,9 @@ static int annotated_source__addr_fmt_width(struct list_head *lines, u64 start)
return 0;
}
int symbol__annotate_printf(struct map_symbol *ms, struct evsel *evsel)
int hist_entry__annotate_printf(struct hist_entry *he, struct evsel *evsel)
{
struct map_symbol *ms = &he->ms;
struct map *map = ms->map;
struct symbol *sym = ms->sym;
struct dso *dso = map__dso(map);
@@ -1600,8 +1601,9 @@ static void symbol__calc_lines(struct map_symbol *ms, struct rb_root *root)
annotation__calc_lines(notes, ms, root);
}
int symbol__tty_annotate2(struct map_symbol *ms, struct evsel *evsel)
int hist_entry__tty_annotate2(struct hist_entry *he, struct evsel *evsel)
{
struct map_symbol *ms = &he->ms;
struct dso *dso = map__dso(ms->map);
struct symbol *sym = ms->sym;
struct rb_root source_line = RB_ROOT;
@@ -1635,8 +1637,9 @@ int symbol__tty_annotate2(struct map_symbol *ms, struct evsel *evsel)
return 0;
}
int symbol__tty_annotate(struct map_symbol *ms, struct evsel *evsel)
int hist_entry__tty_annotate(struct hist_entry *he, struct evsel *evsel)
{
struct map_symbol *ms = &he->ms;
struct dso *dso = map__dso(ms->map);
struct symbol *sym = ms->sym;
struct rb_root source_line = RB_ROOT;
@@ -1660,7 +1663,7 @@ int symbol__tty_annotate(struct map_symbol *ms, struct evsel *evsel)
print_summary(&source_line, dso__long_name(dso));
}
symbol__annotate_printf(ms, evsel);
hist_entry__annotate_printf(he, evsel);
annotated_source__purge(symbol__annotation(sym)->src);