Jeff Johnson
c41cc3c287
siox: bus-gpio: add missing MODULE_DESCRIPTION()
...
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/siox/siox-bus-gpio.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com >
Acked-by: Thorsten Scherer <t.scherer@eckelmann.de >
Link: https://lore.kernel.org/r/20240530-md-siox-bus-gpio-v1-1-6a2f943ac8ad@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-06-04 17:41:53 +02:00
Uwe Kleine-König
db418d5f1c
siox: bus-gpio: Simplify using devm_siox_* functions
...
With the devm variant of siox_master_allocate() and
siox_master_register() the remove callback can be dropped. This also
simplifies the error paths in the probe function.
Acked-by: Thorsten Scherer <t.scherer@eckelmann.de >
Link: https://lore.kernel.org/r/e3c598de536deadc7efef9c21ccb49d31eb240a9.1708328466.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
2024-03-08 22:01:10 +01:00
Uwe Kleine-König
2c12932b8e
siox: Don't pass the reference on a master in siox_master_register()
...
While it's technically fine to pass the ownership of the reference on
a struct siox_master from the caller of siox_master_register() to the
framework this is hard to use. Instead let the framework take its own
reference (that is freed in siox_master_unregister()) and drop the bus
driver's reference in its remove callback.
Acked-by: Thorsten Scherer <t.scherer@eckelmann.de >
Link: https://lore.kernel.org/r/1e8d09d17848e58e8fc6a46278b5e8fb0cf4618a.1708328466.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
2024-03-08 22:01:09 +01:00
Thorsten Scherer
75020f2df6
siox: Simplify error handling via dev_err_probe()
...
commit a787e5400a ("driver core: add device probe log helper")
introduced a helper for a common error checking pattern. Use it.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de >
Link: https://lore.kernel.org/r/20210616061736.3786173-2-t.scherer@eckelmann.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-06-24 15:46:34 +02:00
Randy Dunlap
ac3167257b
headers: separate linux/mod_devicetable.h from linux/platform_device.h
...
At over 4000 #includes, <linux/platform_device.h> is the 9th most
#included header file in the Linux kernel. It does not need
<linux/mod_devicetable.h>, so drop that header and explicitly add
<linux/mod_devicetable.h> to source files that need it.
4146 #include <linux/platform_device.h>
After this patch, there are 225 files that use <linux/mod_devicetable.h>,
for a reduction of around 3900 times that <linux/mod_devicetable.h>
does not have to be read & parsed.
225 #include <linux/mod_devicetable.h>
This patch was build-tested on 20 different arch-es.
It also makes these drivers SubmitChecklist#1 compliant.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org >
Reported-by: kbuild test robot <lkp@intel.com > # drivers/media/platform/vimc/
Reported-by: kbuild test robot <lkp@intel.com > # drivers/pinctrl/pinctrl-u300.c
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-07-07 17:52:26 +02:00
Uwe Kleine-König
fd639726bf
siox: add gpio bus driver
...
This bus driver uses GPIOs to control the four SIOX bus lines.
Acked-by: Gavin Schenk <g.schenk@eckelmann.de >
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-12-19 10:56:53 +01:00