Heiner Kallweit
9df39924c4
hwmon: (gsc) Simplify specifying static visibility attribute
...
Use new member visible of struct hwmon_ops to simplify specifying
the static attribute visibility.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com >
Message-ID: <bd909a2c-23ee-437d-9bd4-858119f6f266@gmail.com >
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2024-11-10 14:48:06 -08:00
Liao Chen
fa8df3cbd3
hwmon: (gsc-hwmon) fix module autoloading
...
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.
Signed-off-by: Liao Chen <liaochen4@huawei.com >
Message-ID: <20240814024555.3875387-1-liaochen4@huawei.com >
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2024-08-27 08:10:23 -07:00
Javier Carrasco
0811b8b03b
hwmon: (gsc-hwmon) constify read-only struct regmap_bus
...
`gsc_hwmon_regmap_bus` is not modified and can be declared as const to
move its data to a read-only section.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com >
Link: https://lore.kernel.org/r/20240705-hwmon-const-regmap-v1-1-7cde543ba818@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2024-07-05 14:37:01 -07:00
Javier Carrasco
1ee1237941
hwmon: (gsc-hwmon) use device_for_each_child_node_scoped()
...
Switch to the _scoped() version introduced in commit 365130fd47
("device property: Introduce device_for_each_child_node_scoped()")
to remove the need for manual calling of fwnode_handle_put() in the
paths where the code exits the loop early.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com >
Link: https://lore.kernel.org/r/20240404-hwmon_device_for_each_child_node_scoped-v1-2-53997abde43c@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2024-06-08 16:07:33 -07:00
Tim Harvey
a6d80df47e
hwmon: (gsc-hwmon) fix fan pwm temperature scaling
...
The GSC fan pwm temperature register is in centidegrees celcius but the
Linux hwmon convention is to use milidegrees celcius. Fix the scaling.
Fixes: 3bce5377ef ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com >
Link: https://lore.kernel.org/r/20230606153004.1448086-1-tharvey@gateworks.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2023-06-08 06:35:52 -07:00
Christophe JAILLET
59882c7f67
hwmon: (gsc-hwmon) Switch to flexible array to simplify code
...
Using flexible array is more straight forward. It
- saves 1 pointer in the 'gsc_hwmon_platform_data' structure
- saves an indirection when using this array
- saves some LoC and avoids some always spurious pointer arithmetic
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Link: https://lore.kernel.org/r/61a23e1d642397cfcecc4ac3bb0ab485d257987d.1668936855.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2022-12-04 16:45:03 -08:00
Liang He
7f62cf781e
hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API
...
In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
the of_find_compatible_node() which will automatically call
of_node_put() for the 'from' argument.
Fixes: 3bce5377ef ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Liang He <windhl@126.com >
Co-developed-by: Mengda Chen <chenmengda2009@163.com >
Signed-off-by: Mengda Chen <chenmengda2009@163.com >
Link: https://lore.kernel.org/r/20220916154708.3084515-1-chenmengda2009@163.com
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2022-09-19 06:16:39 -07:00
Liang He
b674bcb13f
hwmon: (gsc-hwmon) Add missing of_node_put()
...
In gsc_hwmon_get_devtree_pdata(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com >
Link: https://lore.kernel.org/r/20220616114024.3985770-1-windhl@126.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2022-07-13 08:38:20 -07:00
Tim Harvey
7497d4a66c
hwmon: (gsc-hwmon) add fan sensor
...
Add a fan sensor to report RPM's from a fan tach input.
Signed-off-by: Tim Harvey <tharvey@gateworks.com >
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2020-09-23 09:42:41 -07:00
Tim Harvey
c1ae18d313
hwmon: (gsc-hwmon) Scale temperature to millidegrees
...
The GSC registers report temperature in decidegrees celcius so we
need to scale it to represent the hwmon sysfs API of millidegrees.
Cc: stable@vger.kernel.org
Fixes: 3bce5377ef ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com >
Link: https://lore.kernel.org/r/1598548824-16898-1-git-send-email-tharvey@gateworks.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2020-08-27 12:47:55 -07:00
Tim Harvey
a4872f7a4b
hwmon: (gsc) add 16bit pre-scaled voltage mode
...
add a 16-bit pre-scaled voltage mode to adc and clarify that existing
pre-scaled mode is 24bit.
Signed-off-by: Tim Harvey <tharvey@gateworks.com >
Reviewed-by: Guenter Roeck <linux@roeck-us.net >
Link: https://lore.kernel.org/r/1591714640-10332-3-git-send-email-tharvey@gateworks.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
2020-07-19 16:25:21 -07:00
Tim Harvey
3bce5377ef
hwmon: Add Gateworks System Controller support
...
The Gateworks System Controller has a hwmon sub-component that exposes
up to 16 ADC's, some of which are temperature sensors, others which are
voltage inputs. The ADC configuration (register mapping and name) is
configured via device-tree and varies board to board.
Signed-off-by: Tim Harvey <tharvey@gateworks.com >
Reviewed-by: Guenter Roeck <linux@roeck-us.net >
Signed-off-by: Lee Jones <lee.jones@linaro.org >
2020-05-20 10:29:17 +01:00