Swapnil Jakhade
078e9e9211
phy: cadence: Sierra: Prepare driver to add support for multilink configurations
...
Sierra driver currently supports single link configurations only. Prepare
driver to support multilink multiprotocol configurations along with
different SSC modes.
Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com >
Reviewed-by: Aswath Govindraju <a-govindraju@ti.com >
Link: https://lore.kernel.org/r/20211223060137.9252-3-sjakhade@cadence.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-27 16:35:08 +05:30
Swapnil Jakhade
c3c11d5534
phy: cadence: Sierra: Use of_device_get_match_data() to get driver data
...
Use of_device_get_match_data() to get driver data instead of boilerplate
code.
Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com >
Reviewed-by: Aswath Govindraju <a-govindraju@ti.com >
Link: https://lore.kernel.org/r/20211223060137.9252-2-sjakhade@cadence.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-27 16:35:08 +05:30
Miaoqian Lin
399c91c3f3
phy: mediatek: Fix missing check in mtk_mipi_tx_probe
...
The of_device_get_match_data() function may return NULL.
Add check to prevent potential null dereference.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Link: https://lore.kernel.org/r/20211224082103.7658-1-linmq006@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-27 15:58:03 +05:30
Ryuta NAKANISHI
898c7a9ec8
phy: uniphier-usb3ss: fix unintended writing zeros to PHY register
...
Similar to commit 4a90bbb478 ("phy: uniphier-pcie: Fix updating phy
parameters"), in function uniphier_u3ssphy_set_param(), unintentionally
write zeros to other fields when writing PHY registers.
Fixes: 5ab43d0f86 ("phy: socionext: add USB3 PHY driver for UniPhier SoC")
Signed-off-by: Ryuta NAKANISHI <nakanishi.ryuta@socionext.com >
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1640150369-4134-1-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:38 +05:30
Chunfeng Yun
33d18746fa
phy: phy-mtk-tphy: use new io helpers to access register
...
Use new helpers mtk_phy_clear/set/update_bits() to access registers
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com >
Link: https://lore.kernel.org/r/20211218082802.5256-5-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:38 +05:30
Chunfeng Yun
9520bbf3cb
phy: phy-mtk-xsphy: use new io helpers to access register
...
Use new helpers mtk_phy_clear/set/update_bits() to access registers
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com >
Link: https://lore.kernel.org/r/20211218082802.5256-4-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:37 +05:30
Chunfeng Yun
1371b9a563
phy: mediatek: add helpers to update bits of registers
...
Add three helpers mtk_phy_clear/set/update_bits() for registers operation
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com >
Link: https://lore.kernel.org/r/20211218082802.5256-3-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:37 +05:30
Chunfeng Yun
6f2b033cb8
phy: phy-mtk-tphy: add support efuse setting
...
Due to some SoCs have a bit shift issue that will drop a bit for usb3
phy or pcie phy, fix it by adding software efuse reading and setting,
but only support it optionally for version 2/3.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com >
Link: https://lore.kernel.org/r/20211218082802.5256-2-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:37 +05:30
Dmitry Baryshkov
2c91bf6bf2
phy: qcom-qmp: Add SM8450 PCIe1 PHY support
...
There are two different PCIe PHYs on SM8450, one having one lane (v5)
and another with two lanes (v5.20). This commit adds support for the
second PCIe phy.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211218141754.503661-3-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-24 10:06:37 +05:30
Peter Geis
42b559727a
phy: phy-rockchip-inno-usb2: add rk3568 support
...
The rk3568 usb2phy is a standalone device with a single muxed interrupt.
Add support for the registers to the usb2phy driver.
Signed-off-by: Peter Geis <pgwipeout@gmail.com >
Tested-by: Michael Riesch <michael.riesch@wolfvision.net >
Link: https://lore.kernel.org/r/20211215210252.120923-7-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-23 16:54:48 +05:30
Peter Geis
ed2b5a8e6b
phy: phy-rockchip-inno-usb2: support muxed interrupts
...
The rk3568 usb2phy has a single muxed interrupt that handles all
interrupts.
Allow the driver to plug in only a single interrupt as necessary.
Signed-off-by: Peter Geis <pgwipeout@gmail.com >
Tested-by: Michael Riesch <michael.riesch@wolfvision.net >
Link: https://lore.kernel.org/r/20211215210252.120923-6-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-23 16:54:48 +05:30
Peter Geis
e6915e1acc
phy: phy-rockchip-inno-usb2: support standalone phy nodes
...
New Rockchip devices have the usb2 phy devices as standalone nodes
instead of children of the grf node.
Allow the driver to find the grf node from a phandle.
Signed-off-by: Peter Geis <pgwipeout@gmail.com >
Tested-by: Michael Riesch <michael.riesch@wolfvision.net >
Link: https://lore.kernel.org/r/20211215210252.120923-5-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-23 16:54:48 +05:30
Peter Geis
9c19c531dc
phy: phy-rockchip-inno-usb2: support #address_cells = 2
...
New Rockchip devices have the usb phy nodes as standalone devices.
These nodes have register nodes with #address_cells = 2, but only use 32
bit addresses.
Adjust the driver to check if the returned address is "0", and adjust
the index in that case.
Signed-off-by: Peter Geis <pgwipeout@gmail.com >
Tested-by: Michael Riesch <michael.riesch@wolfvision.net >
Link: https://lore.kernel.org/r/20211215210252.120923-4-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-23 16:54:48 +05:30
Dmitry Baryshkov
107ba9bf49
phy: qcom-qmp: Add SM8450 PCIe0 PHY support
...
There are two different PCIe PHYs on SM8450, one having one lane (v5)
and another with two lanes (v5.20). This commit adds support for the
first PCIe phy only, support for the second PCIe PHY is coming in next
commits.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211214225846.2043361-4-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-18 11:25:07 +05:30
Jakub Kicinski
7cd2802d74
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
...
No conflicts.
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2021-12-16 16:13:19 -08:00
Vinod Koul
6ad102e05d
phy: qcom-qmp: Add SM8450 USB QMP PHYs
...
Add support for the USB DP & UNI PHYs found on SM8450. This is same as
the phy version used on SM8350 and sequences turned out to be same, so
use the same table from SM8350 for this as well.
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211213131450.535775-3-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-16 12:06:01 +05:30
Vinod Koul
c8d09c7ebc
phy: freescale: pcie: explicitly add bitfield.h
...
kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <lkp@intel.com >
Fixes: 1aa97b0022 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com >
Link: https://lore.kernel.org/r/20211215060834.921617-1-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-15 20:50:43 +05:30
Richard Zhu
1aa97b0022
phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver
...
Add the standalone i.MX8 PCIe PHY driver.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com >
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com >
Reviewed-by: Tim Harvey <tharvey@gateworks.com >
Tested-by: Tim Harvey <tharvey@gateworks.com >
Link: https://lore.kernel.org/r/1638432158-4119-6-git-send-email-hongxing.zhu@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-14 20:02:53 +05:30
Colin Ian King
b156117aed
phy: rockchip-inno-usb2: remove redundant assignment to variable delay
...
Variable delay is being assigned to zero and the code falls through to
the next case in a switch statement that returns out of the function.
The variable is never read in this scenario and so the assignment is
redundant and can be removed.
Cleans up scan-build static analysis warning:
drivers/phy/rockchip/phy-rockchip-inno-usb2.c:753:3: warning: Value
stored to 'delay' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com >
Link: https://lore.kernel.org/r/20211211180054.525368-1-colin.i.king@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-14 14:45:07 +05:30
Horatiu Vultur
9d031a51b3
phy: lan966x: Remove set_speed function
...
Remove the set_speed function and allow the driver to figure out the
speed at which needs to configure the serdes based on the interface type.
Fixes: 305524902a ("phy: Add lan966x ethernet serdes PHY driver")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com >
Link: https://lore.kernel.org/r/20211211214717.1284306-1-horatiu.vultur@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-14 14:24:48 +05:30
Miaoqian Lin
16c57fff83
phy: ti: Use IS_ERR_OR_NULL() to clean code
...
Use IS_ERR_OR_NULL() to make the code cleaner.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com >
Link: https://lore.kernel.org/r/20211212142226.23674-1-linmq006@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-14 13:10:03 +05:30
Miaoqian Lin
045a31b955
phy: tegra: xusb: Fix return value of tegra_xusb_find_port_node function
...
callers of tegra_xusb_find_port_node() function only do NULL checking for
the return value. return NULL instead of ERR_PTR(-ENOMEM) to keep
consistent.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com >
Acked-by: Thierry Reding <treding@nvidia.com >
Link: https://lore.kernel.org/r/20211213020507.1458-1-linmq006@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-14 13:07:21 +05:30
Guo Zhengkui
e87f13c33e
phy: qcom: use struct_size instead of sizeof
...
Use struct_size() to get the accurate size of `clk_hw_onecell_data`
with a variable size array, instead of sizeof(data) to get the size
of a pointer.
Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com >
Fixes: f199223cb4 ("phy: qcom: Introduce new eDP PHY driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211209032114.9416-1-guozhengkui@vivo.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-09 17:24:54 +05:30
Vinod Koul
15aa1f668c
phy: qcom-qmp: Add SM8450 UFS QMP Phy
...
SM8450 UFS seems to use same sequence as SM8350, so reuse the sequence
from SM8450. Add the new clock list for this phy and the new compatible
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Co-developed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Acked-by: Martin K. Petersen <martin.petersen@oracle.com >
Link: https://lore.kernel.org/r/20211201074456.3969849-4-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-07 17:28:55 +05:30
Horatiu Vultur
17dcc120fb
phy: lan966x: Extend lan966x to support multiple phy interfaces.
...
Currently the driver is supporting only the interfaces QSGMII, SGMII,
RGMII and GMII. This patch extend the supported interfaces with
1000BASE-X and 2500BASE-X.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com >
Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk >
Link: https://lore.kernel.org/r/20211130101015.164916-1-horatiu.vultur@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-02 09:49:23 +05:30
Zou Wei
b2b56de9fa
phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe()
...
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Zou Wei <zou_wei@huawei.com >
Link: https://lore.kernel.org/r/1637822289-24534-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-12-02 09:46:33 +05:30
Fabrice Gasnier
77ba6e7ffb
phy: stm32: adopt dev_err_probe for regulators
...
Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
devices_deferred debugfs in case of probe deferral.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com >
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com >
Link: https://lore.kernel.org/r/1635172265-26219-1-git-send-email-fabrice.gasnier@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-26 11:26:51 +05:30
Rafał Miłecki
97ba12d3fe
phy: bcm-ns-usb2: improve printing ref clk errors
...
Improve message & use dev_err_probe() helper which prints actual error
(helpful for debugging) and deals with -EPROBE_DEFER.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl >
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com >
Link: https://lore.kernel.org/r/20211123221521.25323-1-zajec5@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-25 10:45:04 +05:30
Marek Behún
a1fb410a57
phy: marvell: phy-mvebu-cp110-comphy: add support for 5gbase-r
...
Add support for PHY_INTERFACE_MODE_5GBASER mode within the Marvell CP110
common PHY driver.
This is currently only supported via SMC calls to TF-A. Legacy support
may be added later, if needed.
Signed-off-by: Marek Behún <kabel@kernel.org >
Signed-off-by: David S. Miller <davem@davemloft.net >
2021-11-23 12:14:48 +00:00
Rashmi A
97004c1a4c
phy: intel: Add Thunder Bay eMMC PHY support
...
Add support of eMMC PHY for Intel Thunder Bay SoC,
uses the Arasan eMMC phy
Signed-off-by: Rashmi A <rashmi.a@intel.com >
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com >
Link: https://lore.kernel.org/r/20211027115516.4475-5-rashmi.a@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 13:11:52 +05:30
Horatiu Vultur
305524902a
phy: Add lan966x ethernet serdes PHY driver
...
Add the Microchip lan966x ethernet serdes PHY driver for interfaces
available in the lan966x SoC.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com >
Link: https://lore.kernel.org/r/20211116100818.1615762-4-horatiu.vultur@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 13:09:08 +05:30
Aswath Govindraju
be24d24840
phy: phy-can-transceiver: Make devm_gpiod_get optional
...
In some cases the standby/enable gpio can be pulled low/high and would not
be connected to a gpio. The current driver implementation will return an
error in these cases. Therefore, make devm_gpiod_get optional.
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com >
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de >
Link: https://lore.kernel.org/r/20211102112120.23637-1-a-govindraju@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 12:15:08 +05:30
Yang Guang
a463462998
phy: cadence-torrent: use swap() to make code cleaner
...
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Reported-by: Zeal Robot <zealci@zte.com.cn >
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn >
Link: https://lore.kernel.org/r/20211104065233.1833499-1-yang.guang5@zte.com.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:24:30 +05:30
Kunihiko Hayashi
b1f9f4541e
phy: uniphier-ahci: Add support for Pro4 SoC
...
Add support for PHY interface built into ahci controller implemented
in UniPhier Pro4 SoC.
Pro4 SoC distinguishes it from other SoCs as "legacy" SoC, which has GIO
clock line. And Pro4 AHCI-PHY needs to control additional reset lines
("pm", "tx", and "rx").
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1635503947-18250-9-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:21:53 +05:30
Kunihiko Hayashi
7f1abed4e9
phy: uniphier-pcie: Add dual-phy support for NX1 SoC
...
NX1 SoC supports 2 lanes and has dual-phy. Should set appropriate
configuration values to both PHY registers.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1635503947-18250-7-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:21:53 +05:30
Kunihiko Hayashi
25bba42f95
phy: uniphier-pcie: Set VCOPLL clamp mode in PHY register
...
Set VCOPLL clamp mode to mode 0 to avoid hardware unstable issue.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1635503947-18250-6-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:21:53 +05:30
Kunihiko Hayashi
1c1597c802
phy: uniphier-pcie: Add compatible string and SoC-dependent data for NX1 SoC
...
Add basic support for UniPhier NX1 SoC. This includes a compatible string,
SoC-dependent data, and a function that set to 2-lane mode.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1635503947-18250-5-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:21:53 +05:30
Kunihiko Hayashi
877e8d28bc
phy: uniphier-usb3: Add compatible string for NX1 SoC
...
Add basic support for UniPhier NX1 SoC. This includes a compatible string
and the same SoC-dependent data as LD20/PXs3 SoCs.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com >
Link: https://lore.kernel.org/r/1635503947-18250-3-git-send-email-hayashi.kunihiko@socionext.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:21:53 +05:30
Martin Blumenstingl
e45dbd3a4b
phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2
...
Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register
region. Unfortunately only few register bits are documented. For
HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor
kernel.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com >
Link: https://lore.kernel.org/r/20211020195107.1564533-3-martin.blumenstingl@googlemail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 11:17:49 +05:30
Dan Carpenter
f0ae8685b2
phy: HiSilicon: Fix copy and paste bug in error handling
...
This should check ">pmctrl" instead of "->sysctrl". This bug could
potentially lead to a crash if we dereference the error pointer.
Fixes: 73075011ff ("phy: HiSilicon: Add driver for Kirin 970 PCIe PHY")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org >
Link: https://lore.kernel.org/r/20211117074843.GE5237@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 10:42:13 +05:30
Bjorn Andersson
f199223cb4
phy: qcom: Introduce new eDP PHY driver
...
Many recent Qualcomm platforms comes with native DP and eDP support.
This consists of a controller in the MDSS and a QMP-like PHY.
While similar to the well known QMP block, the eDP PHY only has TX lanes
and the programming sequences are slightly different. Rather than
continuing the trend of parameterize the QMP driver to pieces, this
introduces the support as a new driver.
The registration of link and pixel clocks are borrowed from the QMP
driver. The non-DP link frequencies are omitted for now.
The eDP PHY is very similar to the dedicated (non-USB) DP PHY, but only
the prior is supported for now.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Stephen Boyd <swboyd@chromium.org >
Link: https://lore.kernel.org/r/20211103234410.1352424-2-bjorn.andersson@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 10:40:17 +05:30
Vinod Koul
7947113fd0
phy: ti: omap-usb2: Fix the kernel-doc style
...
The documentation uses incorrect style, so fix that.
drivers/phy/ti/phy-omap-usb2.c:102: warning: Function parameter or member 'comparator' not described in 'omap_usb2_set_comparator'
While at it, use a single line for function description
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Liam Beguin <liambeguin@gmail.com >
Link: https://lore.kernel.org/r/20211120061531.410771-2-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 10:38:24 +05:30
Vinod Koul
0d1c7e5544
phy: qualcomm: ipq806x-usb: Fix kernel-doc style
...
The functions are documented but there were style issues, so fix
the style and add missing description for phy_dwc3
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:130:
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:174:
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:212: warning:
This comment starts with '/**', but isn't a kernel-doc comment.
Refer Documentation/doc-guide/kernel-doc.rst
Reviewed-by: Randy Dunlap <rdunlap@infradead.org >
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211120061531.410771-1-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 10:38:24 +05:30
Rafał Miłecki
d3bc6269e2
phy: bcm-ns-usb2: support updated DT binding with PHY reg space
...
Updated DT binding maps just a PHY's register space instead of the whole
DMU block. Accessing a common CRU reg is handled using syscon &
regmap.
The old binding has been deprecated and remains supported as a fallback
method.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl >
Link: https://lore.kernel.org/r/20211026093716.5567-1-zajec5@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-23 10:22:56 +05:30
Vinod Koul
466b1516e7
phy: ti: tusb1210: Fix the kernel-doc warn
...
The comment is not kernel-doc one and starts with /**, so fix that.
drivers/phy/ti/phy-tusb1210.c:16: warning: expecting prototype for tusb1210.c(). Prototype was for TUSB1210_VENDOR_SPECIFIC2() instead
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Liam Beguin <liambeguin@gmail.com >
Link: https://lore.kernel.org/r/20211116103951.34482-6-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-20 11:33:23 +05:30
Vinod Koul
1de7c6ad9a
phy: qualcomm: usb-hsic: Fix the kernel-doc warn
...
The comment is not kernel-doc one and starts with /**, so fix that.
drivers/phy/qualcomm/phy-qcom-usb-hsic.c:3: warning:
This comment starts with '/**', but isn't a kernel-doc comment.
Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211116103951.34482-4-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-20 11:33:23 +05:30
Vinod Koul
e697ffe39a
phy: qualcomm: qmp: Add missing struct documentation
...
dp-* members were added to qmp_phy_combo_cfg but documentation was
missed, so add that.
drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_aux_cfg' not described in 'qmp_phy'
drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_opts' not described in 'qmp_phy'
drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_clks' not described in 'qmp_phy'
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211116103951.34482-3-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-20 11:33:23 +05:30
Vinod Koul
31c66bfa95
phy: mvebu-cp110-utmi: Fix kernel-doc warns
...
Fix the format and add description for ops to fix the below warnings:
drivers/phy/marvell/phy-mvebu-cp110-utmi.c:94: warning: Function parameter or member 'syscon' not described in 'mvebu_cp110_utmi'
drivers/phy/marvell/phy-mvebu-cp110-utmi.c:94: warning: Function parameter or member 'ops' not described in 'mvebu_cp110_utmi'
Signed-off-by: Vinod Koul <vkoul@kernel.org >
Link: https://lore.kernel.org/r/20211116103951.34482-1-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-20 11:33:22 +05:30
Randy Dunlap
7adaf921b6
phy: ti: report 2 non-kernel-doc comments
...
Do not use "/**" to begin a non-kernel-doc comment.
Fixes these build warnings:
drivers/phy/ti/phy-am654-serdes.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* PCIe SERDES driver for AM654x SoC
drivers/phy/ti/phy-j721e-wiz.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Wrapper driver for SERDES used in J721E
Signed-off-by: Randy Dunlap <rdunlap@infradead.org >
Reported-by: kernel test robot <lkp@intel.com >
Cc: Kishon Vijay Abraham I <kishon@ti.com >
Cc: Vinod Koul <vkoul@kernel.org >
Cc: linux-phy@lists.infradead.org
Link: https://lore.kernel.org/r/20211115030559.13994-1-rdunlap@infradead.org
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-16 15:31:30 +05:30
Amelie Delaunay
8755e9e6d0
phy: stm32: fix st,slow-hs-slew-rate with st,decrease-hs-slew-rate
...
st,decrease-hs-slew-rate is described in phy-stm32-usbphyc.yaml. Then
fix the property name in driver.
Fixes: 2f5e9f815a ("phy: stm32: add phy tuning support")
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com >
Link: https://lore.kernel.org/r/20211026154817.198937-1-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org >
2021-11-16 15:28:51 +05:30