Dave Airlie
7dd1be30f0
Merge tag 'amd-drm-next-6.3-2023-01-20' of https://gitlab.freedesktop.org/agd5f/linux into drm-next
...
amd-drm-next-6.3-2023-01-20:
amdgpu:
- Secure display fixes
- Fix scaling
- Misc code cleanups
- Display BW alloc logic updates
- DCN 3.2 fixes
- Fix power reporting on certain firmwares for CZN/RN
- SR-IOV fixes
- Link training cleanup and code rework
- HDCP fixes
- Reserved VMID fix
- Documentation updates
- Colorspace fixes
- RAS updates
- GC11.0 fixes
- VCN instance harvesting fixes
- DCN 3.1.4/5 workarounds for S/G displays
- Add PCIe info to the INFO IOCTL
amdkfd:
- XNACK fix
UAPI:
- Add PCIe gen/lanes info to the amdgpu INFO IOCTL
Nesa ultimately plans to use this to make decisions about buffer placement optimizations
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20790
Signed-off-by: Dave Airlie <airlied@redhat.com >
From: Alex Deucher <alexander.deucher@amd.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20230120234523.7610-1-alexander.deucher@amd.com
2023-01-25 12:07:53 +10:00
Daniel Vetter
b8f55f24bc
Merge tag 'drm-misc-next-2023-01-19' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
...
drm-misc-next for $kernel-version:
UAPI Changes:
Cross-subsystem Changes:
Core Changes:
* Cleanup unneeded include statements wrt <linux/fb.h>, <drm/drm_fb_helper.h>
and <drm/drm_crtc_helper.h>
* Remove unused helper DRM_DEBUG_KMS_RATELIMITED()
* fbdev: Remove obsolete aperture field from struct fb_device, plus
driver cleanups; Remove unused flag FBINFO_MISC_FIRMWARE
* MIPI-DSI: Fix brightness, plus rsp. driver updates
* scheduler: Deprecate drm_sched_resubmit_jobs()
* ttm: Fix MIPS build; Remove ttm_bo_wait(); Documentation fixes
Driver Changes:
* Remove obsolete drivers for userspace modesetting i810, mga, r128,
savage, sis, tdfx, via
* bridge: Support CDNS DSI J721E, plus DT bindings; lt9611: Various
fixes and improvements; sil902x: Various fixes; Fixes
* nouveau: Removed support for legacy ioctls; Replace zero-size array;
Cleanups
* panel: Fixes
* radeon: Use new DRM logging helpers
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
From: Thomas Zimmermann <tzimmermann@suse.de >
Link: https://patchwork.freedesktop.org/patch/msgid/Y8kDk5YX7Yz3eRhM@linux-uq9g
2023-01-24 17:36:29 +01:00
Deepak R Varma
e5975d7816
drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks addition
...
For bit mask addition, it is recommended to use or operator "|" instead
of numerical addition as the former is quicker and cleaner. Change
suggested by orplus.cocci Coccinelle semantic patch.
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Deepak R Varma <drv@mailo.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-17 16:11:51 -05:00
Deepak R Varma
d3d3b89451
drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition
...
For bit mask addition, it is recommended to use or operator "|" instead
of numerical addition as the former is quicker and cleaner. Change
suggested by orplus.cocci Coccinelle semantic patch.
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Deepak R Varma <drv@mailo.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-17 16:11:51 -05:00
Deepak R Varma
4e18550266
drm/amd/pm/powerplay/smumgr: use bitwise or for addition
...
For bit mask addition, it is recommended to use or operator "|" instead
of numerical addition as the former is quicker and cleaner. Change
suggested by orplus.cocci Coccinelle semantic patch.
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Deepak R Varma <drv@mailo.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-17 16:11:51 -05:00
Alex Deucher
29f5be8dcc
drm/amdgpu/pm: update hwmon power documentation
...
Power reporting is socket power. On APUs this includes
the CPU. Update the documentation to clarify this.
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-17 16:11:51 -05:00
Candice Li
51097df1b2
drm/amd/pm: Support RAS fatal error mode1 reset on smu v13_0_0 and v13_0_10
...
Support RAS fatal error mode1 reset on smu v13_0_0 and v13_0_10.
Signed-off-by: Candice Li <candice.li@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-13 14:59:26 -05:00
jie1zhan
29c472b28b
drm/amdgpu: Correct the power calcultion for Renior/Cezanne.
...
From smu firmware,the value of power is transferred in units of watts.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2321
Fixes: 137aac26a2 ("drm/amdgpu/smu12: fix power reporting on renoir")
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com >
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-13 14:58:38 -05:00
Thomas Zimmermann
77910a625f
drm/amdgpu: Do not include <linux/fb.h>
...
Remove unnecessary include statements for <linux/fb.h>. No functional
changes.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Acked-by: Christian König <christian.koenig@amd.com >
Acked-by: Maxime Ripard <maxime@cerno.tech >
Link: https://patchwork.freedesktop.org/patch/msgid/20230111130206.29974-5-tzimmermann@suse.de
2023-01-13 13:19:13 +01:00
Guchun Chen
45bf79719f
drm/amd/pm/smu13: BACO is supported when it's in BACO state
...
This leverages the logic in smu11. No need to talk to SMU to
check BACO enablement as it's in BACO state already.
Signed-off-by: Guchun Chen <guchun.chen@amd.com >
Reviewed-by: Kenneth Feng <kenneth.feng@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-10 18:04:45 -05:00
Mario Limonciello
79da290ef6
drm/amd: Use amdgpu_ucode_release helper for si
...
The `amdgpu_ucode_release` helper is replacing all calls
to release_firmware.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-10 14:32:58 -05:00
Mario Limonciello
778af6661c
drm/amd: Use amdgpu_ucode_release helper for powerplay
...
The `amdgpu_ucode_release` helper is replacing all calls to
release_firmware.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-10 14:32:58 -05:00
Mario Limonciello
32806038aa
drm/amd: Load SMU microcode during early_init
...
This will ensure that the microcode is available before the firmware
framebuffer has been destroyed.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-10 14:32:57 -05:00
Mario Limonciello
315d1716d6
drm/amd: Use amdgpu_ucode_* helpers for SMU
...
The `amdgpu_ucode_request` helper will ensure that the return code for
missing firmware is -ENODEV so that early_init can fail.
The `amdgpu_ucode_release` helper is for symmetry on unloading.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-10 14:32:57 -05:00
Mario Limonciello
755f32a39e
drm/amd: Convert SMUv13 microcode to use amdgpu_ucode_ip_version_decode
...
The special case for the one dGPU has been moved into
`amdgpu_ucode_ip_version_decode`, so simplify this code.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Acked-by: Christian König <christian.koenig@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-09 16:27:51 -05:00
Mario Limonciello
6b54496238
drm/amd: Convert SMUv11 microcode to use amdgpu_ucode_ip_version_decode
...
Remove the special casing from SMU v11 code. No intended functional
changes.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com >
Acked-by: Christian König <christian.koenig@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-09 16:27:43 -05:00
Evan Quan
3693c1aea9
drm/amd/pm: add the missing mapping for PPT feature on SMU13.0.0 and 13.0.7
...
Then we are able to set a new ppt limit via the hwmon interface(power1_cap).
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-05 11:43:37 -05:00
Evan Quan
c595637f8a
drm/amd/pm: correct the reference clock for fan speed(rpm) calculation
...
Correct the reference clock as 25Mhz for SMU13 fan speed calculation.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-05 11:43:24 -05:00
Christian König
58ab2c08d7
drm/amdgpu: use VRAM|GTT for a bunch of kernel allocations
...
Technically all of those can use GTT as well, no need to force things
into VRAM.
Signed-off-by: Christian König <christian.koenig@amd.com >
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com >
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2023-01-03 16:49:54 -05:00
Evan Quan
0b93c54341
drm/amd/pm: correct the fan speed retrieving in PWM for some SMU13 asics
...
For SMU 13.0.0 and 13.0.7, the output from PMFW is in percent. Driver
need to convert that into correct PMW(255) based.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-20 12:47:36 -05:00
Evan Quan
7f35c54cc2
drm/amd/pm: bump SMU13.0.0 driver_if header to version 0x34
...
To fit the latest PMFW and suppress the warning emerged on driver loading.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-20 12:47:22 -05:00
Evan Quan
b2bfb48a31
drm/amd/pm: add support for WINDOW3D profile mode on SMU13.0.0
...
Add the support for WINDOW3D profile mode as for other profile modes.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-20 12:47:14 -05:00
Arnd Bergmann
76a95b833a
drm/amd/pm: avoid large variable on kernel stack
...
The activity_monitor_external[] array is too big to fit on the
kernel stack, resulting in this warning with clang:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1438:12: error: stack frame size (1040) exceeds limit (1024) in 'smu_v13_0_7_get_power_profile_mode' [-Werror,-Wframe-larger-than]
Use dynamic allocation instead. It should also be possible to
have single element here instead of the array, but this seems
easier.
v2: fix up argument to sizeof() (Alex)
Fixes: 334682ae81 ("drm/amd/pm: enable workload type change on smu_v13_0_7")
Signed-off-by: Arnd Bergmann <arnd@arndb.de >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-20 12:46:35 -05:00
Evan Quan
b1a9557a7d
drm/amd/pm: fulfill powerplay peak profiling mode shader/memory clock settings
...
Enable peak profiling mode shader/memory clock reporting for powerplay
framework.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-15 12:18:47 -05:00
Evan Quan
975b4b1d90
drm/amd/pm: fulfill swsmu peak profiling mode shader/memory clock settings
...
Enable peak profiling mode shader/memory clocks reporting for swsmu
framework.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-15 12:18:40 -05:00
Evan Quan
e1dd28fc5b
drm/amd/pm: drop unused SMU v13 API
...
The API is not in use. And it's unlikely to be used in
the future either.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-12-15 12:18:20 -05:00
Evan Quan
7a18e089ef
drm/amd/pm: update SMU13.0.0 reported maximum shader clock
...
Update the reported maximum shader clock to the value which can
be guarded to be achieved on all cards. This is to align with
Window setting.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-15 12:18:08 -05:00
Evan Quan
32a7819ff8
drm/amd/pm: correct SMU13.0.0 pstate profiling clock settings
...
Correct the pstate standard/peak profiling mode clock settings
for SMU13.0.0.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-15 12:17:55 -05:00
Evan Quan
62b9f835a6
drm/amd/pm: enable GPO dynamic control support for SMU13.0.7
...
To better support UMD pstate profilings, the GPO feature needs
to be switched on/off accordingly.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-15 12:17:44 -05:00
Evan Quan
1794f6a953
drm/amd/pm: enable GPO dynamic control support for SMU13.0.0
...
To better support UMD pstate profilings, the GPO feature needs
to be switched on/off accordingly.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-15 12:16:43 -05:00
Evan Quan
e0607c10eb
drm/amd/pm: add missing SMU13.0.7 mm_dpm feature mapping
...
Without this, the pp_dpm_vclk and pp_dpm_dclk outputs are not with
correct data.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-14 09:48:27 -05:00
Evan Quan
592cd24a08
drm/amd/pm: add missing SMU13.0.0 mm_dpm feature mapping
...
Without this, the pp_dpm_vclk and pp_dpm_dclk outputs are not with
correct data.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
Cc: stable@vger.kernel.org # 6.0.x
2022-12-14 09:48:05 -05:00
Yu Songping
484d7dcc70
swsmu/amdgpu_smu: Fix the wrong if-condition
...
The logical operator '&&' will make
smu->ppt_funcs->set_gfx_power_up_by_imu segment fault when
smu->ppt_funcs is NULL.
Signed-off-by: Yu Songping <yusongping@huawei.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:37 -05:00
Tim Huang
069a5af97c
drm/amdgpu/pm: use the specific mailbox registers only for SMU IP v13.0.4
...
The SMU IP v13.0.4 ppt interface is shared by IP v13.0.11, they use
the different mailbox register offset. So use the specific mailbox
registers offset for v13.0.4.
Signed-off-by: Tim Huang <tim.huang@amd.com >
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:37 -05:00
Yifan Zhang
9f83e61201
drm/amdgpu/pm: add GFXOFF control IP version check for SMU IP v13.0.11
...
Enable the SMU IP v13.0.11 GFXOFF control
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:37 -05:00
Yifan Zhang
51e7a21687
drm/amdgpu: add smu 13 support for smu 13.0.11
...
this patch to add smu 13 support for smu 13.0.11.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:37 -05:00
Yifan Zhang
16412a9436
drm/amdgpu/pm: enable swsmu for SMU IP v13.0.11
...
Add the entry to set the ppt functions for SMU IP v13.0.11.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com >
Reviewed-by: Aaron Liu <aaron.liu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:37 -05:00
Guchun Chen
86a3c691db
drm/amd/pm/smu11: poll BACO status after RPM BACO exits
...
After executing BACO exit, driver needs to poll the status
to ensure FW has completed BACO exit sequence to prevent
timing issue.
v2: use usleep_range to replace msleep to fix checkpatch.pl warnings
Signed-off-by: Guchun Chen <guchun.chen@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:35 -05:00
Guchun Chen
6dca7efe6e
drm/amd/pm/smu11: BACO is supported when it's in BACO state
...
Return true early if ASIC is in BACO state already, no need
to talk to SMU. It can fix the issue that driver was not
calling BACO exit at all in runtime pm resume, and a timing
issue leading to a PCI AER error happened eventually.
Fixes: 8795e182b0 ("PCI/portdrv: Don't disable AER reporting in get_port_device_capability()")
Suggested-by: Lijo Lazar <lijo.lazar@amd.com >
Signed-off-by: Guchun Chen <guchun.chen@amd.com >
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-29 11:03:35 -05:00
Luben Tuikov
abd51738fe
drm/amdgpu: Fix minmax warning
...
Fix minmax warning by using min_t() macro and explicitly specifying
the assignment type.
Cc: Alex Deucher <Alexander.Deucher@amd.com >
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com >
Reviewed-by: Alex Deucher <Alexander.Deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-23 10:31:30 -05:00
lyndonli
ef5fca9f72
drm/amdgpu: add the fan abnormal detection feature
...
Update the SW CTF limit from existing register
when there's a fan failure detected via SMU interrupt.
Signed-off-by: lyndonli <Lyndon.Li@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Reviewed-by: Kenneth Feng <kenneth.feng@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-23 09:47:15 -05:00
lyndonli
1ec13219a1
drm/amd/pm: update driver if header for smu_13_0_7
...
update driver if header for smu_13_0_7
Signed-off-by: lyndonli <Lyndon.Li@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Reviewed-by: Kenneth Feng <kenneth.feng@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-23 09:47:15 -05:00
Candice Li
48aa62f074
drm/amd/pm: Enable bad memory page/channel recording support for smu v13_0_0
...
Send message to SMU to update bad memory page and bad channel info.
Signed-off-by: Candice Li <candice.li@amd.com >
Reviewed-by: Evan Quan <evan.quan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-23 09:47:14 -05:00
Dan Carpenter
d27252b570
amdgpu/pm: prevent array underflow in vega20_odn_edit_dpm_table()
...
In the PP_OD_EDIT_VDDC_CURVE case the "input_index" variable is capped at
2 but not checked for negative values so it results in an out of bounds
read. This value comes from the user via sysfs.
Fixes: d5bf265394 ("drm/amd/powerplay: added vega20 overdrive support V3")
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 13:35:16 -05:00
Evan Quan
9635709a83
drm/amd/pm: fix SMU13 runpm hang due to unintentional workaround
...
The workaround designed for some specific ASICs is wrongly applied
to SMU13 ASICs. That leads to some runpm hang.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Reviewed-by: Feifei Xu <Feifei.Xu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 13:35:16 -05:00
Evan Quan
a60254d25e
drm/amd/pm: enable runpm support over BACO for SMU13.0.7
...
Enable SMU13.0.7 runpm support.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Reviewed-by: Feifei Xu <Feifei.Xu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 13:35:16 -05:00
Evan Quan
8ae5a38c8c
drm/amd/pm: enable runpm support over BACO for SMU13.0.0
...
Enable SMU13.0.0 runpm support.
Signed-off-by: Evan Quan <evan.quan@amd.com >
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com >
Reviewed-by: Feifei Xu <Feifei.Xu@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 13:35:16 -05:00
Guchun Chen
f42c01696e
drm/amdgpu: disable BACO support on more cards
...
Otherwise, some unexpected PCIE AER errors will be observed
in runtime suspend/resume cycle.
Signed-off-by: Guchun Chen <guchun.chen@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 13:35:16 -05:00
Alex Deucher
d09ef24303
drm/amdgpu: clarify DC checks
...
There are several places where we don't want to check
if a particular asic could support DC, but rather, if
DC is enabled. Set a flag if DC is enabled and check
for that rather than if a device supports DC or not.
Acked-by: Christian König <christian.koenig@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-15 11:51:45 -05:00
Gavin Wan
ecc9b6e15a
drm/amdgpu: Ignore stop rlc on SRIOV environment.
...
For SRIOV, the guest driver should not do stop rlc. The host
handles programing RLC.
On SRIOV, the stop rlc will be hang (RLC related registers are
blocked by policy) when the RLCG interface is not enabled.
Reviewed-by: Yang Wang <kevinyang.wang@amd.com >
Acked-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Gavin Wan <Gavin.Wan@amd.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2022-11-10 15:29:46 -05:00