Florian Westphal
9df785aeb7
netfilter: nf_tables: prefer nft_chain_validate
...
[ Upstream commit cff3bd012a ]
nft_chain_validate already performs loop detection because a cycle will
result in a call stack overflow (ctx->level >= NFT_JUMP_STACK_SIZE).
It also follows maps via ->validate callback in nft_lookup, so there
appears no reason to iterate the maps again.
nf_tables_check_loops() and all its helper functions can be removed.
This improves ruleset load time significantly, from 23s down to 12s.
This also fixes a crash bug. Old loop detection code can result in
unbounded recursion:
BUG: TASK stack guard page was hit at ....
Oops: stack guard page: 0000 [#1 ] PREEMPT SMP KASAN
CPU: 4 PID: 1539 Comm: nft Not tainted 6.10.0-rc5+ #1
[..]
with a suitable ruleset during validation of register stores.
I can't see any actual reason to attempt to check for this from
nft_validate_register_store(), at this point the transaction is still in
progress, so we don't have a full picture of the rule graph.
For nf-next it might make sense to either remove it or make this depend
on table->validate_state in case we could catch an error earlier
(for improved error reporting to userspace).
Fixes: 20a69341f2 ("netfilter: nf_tables: add netlink set API")
Signed-off-by: Florian Westphal <fw@strlen.de >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2024-07-18 13:22:41 +02:00
..
2024-06-27 13:52:23 +02:00
2024-06-12 11:39:55 +02:00
2024-06-27 13:52:23 +02:00
2024-01-29 15:43:21 +01:00
2024-01-10 10:52:28 +01:00
2024-01-24 16:21:01 -08:00
2024-01-29 15:43:20 +01:00
2022-02-04 06:30:28 +01:00
2019-07-16 13:16:59 +02:00
2024-01-31 20:40:56 -08:00
2023-11-08 13:52:32 +01:00
2024-02-29 14:24:56 -08:00
2023-02-22 00:28:47 +01:00
2024-02-21 11:57:11 +01:00
2023-09-13 21:57:50 +02:00
2022-09-20 23:50:03 +02:00
2024-03-07 03:10:35 +01:00
2022-08-11 16:50:49 +02:00
2019-06-19 17:09:52 +02:00
2023-10-10 16:34:28 +02:00
2022-09-07 15:55:23 +02:00
2023-10-24 13:16:30 +02:00
2022-01-11 10:41:44 +01:00
2024-02-08 12:10:18 +01:00
2023-03-08 14:25:41 +01:00
2022-07-11 16:25:15 +02:00
2023-07-27 13:45:51 +02:00
2019-06-19 17:09:55 +02:00
2023-07-05 14:42:15 +02:00
2021-06-18 14:47:43 +02:00
2022-11-30 23:01:20 +01:00
2024-01-31 23:13:57 +01:00
2024-01-31 23:07:04 +01:00
2023-02-01 12:18:51 +01:00
2023-11-08 13:52:32 +01:00
2022-08-11 16:50:25 +02:00
2022-02-04 06:30:28 +01:00
2023-06-26 17:18:48 +02:00
2019-05-30 11:26:32 -07:00
2024-06-27 13:52:23 +02:00
2019-07-16 13:16:59 +02:00
2022-07-11 16:25:15 +02:00
2022-02-04 06:30:28 +01:00
2022-06-21 10:50:41 +02:00
2024-06-12 11:39:54 +02:00
2024-04-11 12:13:11 +02:00
2024-06-12 11:39:55 +02:00
2023-07-31 09:11:24 +01:00
2022-07-11 16:25:14 +02:00
2024-07-05 09:37:54 +02:00
2024-06-27 13:52:23 +02:00
2024-01-17 12:02:48 +01:00
2024-02-21 11:57:11 +01:00
2022-09-07 16:46:04 +02:00
2024-01-31 20:40:56 -08:00
2024-02-15 00:20:00 +01:00
2022-09-07 16:46:04 +02:00
2022-11-18 02:15:15 +01:00
2022-09-07 16:46:04 +02:00
2022-05-13 18:56:27 +02:00
2024-01-03 11:17:17 +01:00
2023-10-30 14:36:57 -07:00
2023-11-08 16:40:30 +01:00
2022-09-07 16:46:04 +02:00
2019-07-16 13:16:59 +02:00
2024-02-21 12:03:22 +01:00
2020-07-24 15:41:54 -07:00
2024-03-01 08:42:31 +00:00
2024-07-18 13:22:41 +02:00
2024-01-10 10:52:28 +01:00
2023-07-31 09:11:24 +01:00
2023-10-18 10:26:43 +02:00
2021-05-29 01:04:53 +02:00
2022-07-11 16:25:15 +02:00
2022-06-17 23:31:20 +02:00
2023-04-21 11:34:14 -07:00
2024-01-17 12:02:47 +01:00
2023-11-08 13:52:32 +01:00
2024-07-18 13:22:40 +02:00
2023-06-08 04:00:02 +02:00
2023-06-26 12:59:18 -07:00
2023-11-14 16:16:21 +01:00
2024-04-25 10:42:57 +02:00
2023-11-08 13:52:32 +01:00
2021-05-29 01:04:54 +02:00
2023-07-31 09:11:24 +01:00
2024-02-28 23:52:55 +01:00
2022-11-15 10:46:34 +01:00
2022-11-15 10:53:17 +01:00
2023-05-03 13:49:08 +02:00
2024-03-11 19:53:15 -07:00
2022-11-15 10:46:34 +01:00
2023-12-06 17:15:43 +01:00
2023-12-06 17:15:42 +01:00
2022-03-20 00:29:47 +01:00
2022-03-20 00:29:47 +01:00
2024-06-12 11:39:53 +02:00
2024-02-15 00:20:00 +01:00
2023-11-08 13:52:32 +01:00
2023-06-26 08:05:57 +02:00
2024-01-03 11:17:17 +01:00
2023-10-12 10:28:45 +02:00
2023-03-01 17:23:23 +01:00
2024-01-24 20:01:16 +01:00
2022-11-15 10:46:34 +01:00
2024-07-05 09:37:56 +02:00
2023-07-27 13:45:51 +02:00
2024-06-21 14:40:23 +02:00
2024-01-24 20:02:40 +01:00
2022-11-15 10:46:34 +01:00
2023-07-05 14:42:15 +02:00
2024-02-21 11:57:11 +01:00
2024-06-21 14:40:23 +02:00
2022-11-15 10:46:34 +01:00
2023-03-01 17:23:23 +01:00
2023-06-26 08:05:57 +02:00
2023-07-27 13:45:51 +02:00
2022-03-20 00:29:46 +01:00
2022-03-20 00:29:46 +01:00
2023-06-26 08:05:57 +02:00
2024-06-12 11:39:55 +02:00
2024-04-17 17:43:11 +02:00
2024-04-17 17:43:11 +02:00
2024-02-21 11:57:11 +01:00
2021-05-29 01:04:27 +02:00
2024-04-17 17:43:11 +02:00
2024-02-21 11:57:11 +01:00
2024-04-17 17:43:11 +02:00
2024-01-24 20:02:40 +01:00
2024-01-24 20:02:40 +01:00
2024-01-24 20:02:40 +01:00
2024-01-31 23:07:04 +01:00
2024-01-24 20:02:40 +01:00
2024-02-21 12:03:22 +01:00
2024-02-21 12:03:22 +01:00
2019-06-19 17:09:55 +02:00
2021-06-01 23:53:51 +02:00
2021-08-17 00:45:07 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2018-02-14 21:05:38 +01:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2022-11-18 15:21:00 +01:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:25:15 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-01-22 08:33:37 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2023-03-17 15:16:33 +01:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2023-05-25 12:16:27 +01:00
2023-02-22 21:25:23 -08:00
2021-05-29 01:04:52 +02:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-12-01 09:45:29 +01:00
2021-09-21 03:46:56 +02:00
2019-06-19 17:09:55 +02:00
2023-06-20 22:43:42 +02:00
2023-12-06 17:52:15 +01:00
2024-01-17 12:02:48 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2022-09-07 16:46:03 +02:00
2019-06-19 17:09:55 +02:00
2023-11-08 13:53:36 +01:00
2023-03-22 21:48:59 +01:00
2023-08-22 15:13:21 +02:00
2023-08-30 17:34:01 +02:00
2021-05-03 23:02:44 +02:00
2019-08-13 12:14:26 +02:00
2023-07-29 18:13:41 +01:00
2019-06-19 17:09:55 +02:00
2022-10-11 17:42:58 -06:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2022-07-11 16:40:45 +02:00
2019-06-22 08:59:24 -04:00
2023-03-22 21:48:59 +01:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2022-07-21 00:56:00 +02:00
2021-03-31 22:34:10 +02:00
2023-08-30 17:34:01 +02:00