mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 18:09:56 +00:00
commitfe2b122665upstream. When working on LED support for r8169 I got the following lockdep warning. Easiest way to prevent this scenario seems to be to take the RTNL lock before the trigger_data lock in set_device_name(). ====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc2-next-20231124+ #2 Not tainted ------------------------------------------------------ bash/383 is trying to acquire lock: ffff888103aa1c68 (&trigger_data->lock){+.+.}-{3:3}, at: netdev_trig_notify+0xec/0x190 [ledtrig_netdev] but task is already holding lock: ffffffff8cddf808 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock+0x12/0x20 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (rtnl_mutex){+.+.}-{3:3}: __mutex_lock+0x9b/0xb50 mutex_lock_nested+0x16/0x20 rtnl_lock+0x12/0x20 set_device_name+0xa9/0x120 [ledtrig_netdev] netdev_trig_activate+0x1a1/0x230 [ledtrig_netdev] led_trigger_set+0x172/0x2c0 led_trigger_write+0xf1/0x140 sysfs_kf_bin_write+0x5d/0x80 kernfs_fop_write_iter+0x15d/0x210 vfs_write+0x1f0/0x510 ksys_write+0x6c/0xf0 __x64_sys_write+0x14/0x20 do_syscall_64+0x3f/0xf0 entry_SYSCALL_64_after_hwframe+0x6c/0x74 -> #0 (&trigger_data->lock){+.+.}-{3:3}: __lock_acquire+0x1459/0x25a0 lock_acquire+0xc8/0x2d0 __mutex_lock+0x9b/0xb50 mutex_lock_nested+0x16/0x20 netdev_trig_notify+0xec/0x190 [ledtrig_netdev] call_netdevice_register_net_notifiers+0x5a/0x100 register_netdevice_notifier+0x85/0x120 netdev_trig_activate+0x1d4/0x230 [ledtrig_netdev] led_trigger_set+0x172/0x2c0 led_trigger_write+0xf1/0x140 sysfs_kf_bin_write+0x5d/0x80 kernfs_fop_write_iter+0x15d/0x210 vfs_write+0x1f0/0x510 ksys_write+0x6c/0xf0 __x64_sys_write+0x14/0x20 do_syscall_64+0x3f/0xf0 entry_SYSCALL_64_after_hwframe+0x6c/0x74 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(rtnl_mutex); lock(&trigger_data->lock); lock(rtnl_mutex); lock(&trigger_data->lock); *** DEADLOCK *** 8 locks held by bash/383: #0: ffff888103ff33f0 (sb_writers#3){.+.+}-{0:0}, at: ksys_write+0x6c/0xf0 #1: ffff888103aa1e88 (&of->mutex){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x114/0x210 #2: ffff8881036f1890 (kn->active#82){.+.+}-{0:0}, at: kernfs_fop_write_iter+0x11d/0x210 #3: ffff888108e2c358 (&led_cdev->led_access){+.+.}-{3:3}, at: led_trigger_write+0x30/0x140 #4: ffffffff8cdd9e10 (triggers_list_lock){++++}-{3:3}, at: led_trigger_write+0x75/0x140 #5: ffff888108e2c270 (&led_cdev->trigger_lock){++++}-{3:3}, at: led_trigger_write+0xe3/0x140 #6: ffffffff8cdde3d0 (pernet_ops_rwsem){++++}-{3:3}, at: register_netdevice_notifier+0x1c/0x120 #7: ffffffff8cddf808 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock+0x12/0x20 stack backtrace: CPU: 0 PID: 383 Comm: bash Not tainted 6.7.0-rc2-next-20231124+ #2 Hardware name: Default string Default string/Default string, BIOS ADLN.M6.SODIMM.ZB.CY.015 08/08/2023 Call Trace: <TASK> dump_stack_lvl+0x5c/0xd0 dump_stack+0x10/0x20 print_circular_bug+0x2dd/0x410 check_noncircular+0x131/0x150 __lock_acquire+0x1459/0x25a0 lock_acquire+0xc8/0x2d0 ? netdev_trig_notify+0xec/0x190 [ledtrig_netdev] __mutex_lock+0x9b/0xb50 ? netdev_trig_notify+0xec/0x190 [ledtrig_netdev] ? __this_cpu_preempt_check+0x13/0x20 ? netdev_trig_notify+0xec/0x190 [ledtrig_netdev] ? __cancel_work_timer+0x11c/0x1b0 ? __mutex_lock+0x123/0xb50 mutex_lock_nested+0x16/0x20 ? mutex_lock_nested+0x16/0x20 netdev_trig_notify+0xec/0x190 [ledtrig_netdev] call_netdevice_register_net_notifiers+0x5a/0x100 register_netdevice_notifier+0x85/0x120 netdev_trig_activate+0x1d4/0x230 [ledtrig_netdev] led_trigger_set+0x172/0x2c0 ? preempt_count_add+0x49/0xc0 led_trigger_write+0xf1/0x140 sysfs_kf_bin_write+0x5d/0x80 kernfs_fop_write_iter+0x15d/0x210 vfs_write+0x1f0/0x510 ksys_write+0x6c/0xf0 __x64_sys_write+0x14/0x20 do_syscall_64+0x3f/0xf0 entry_SYSCALL_64_after_hwframe+0x6c/0x74 RIP: 0033:0x7f269055d034 Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d 35 c3 0d 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 48 83 ec 28 48 89 54 24 18 48 RSP: 002b:00007ffddb7ef748 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 0000000000000007 RCX: 00007f269055d034 RDX: 0000000000000007 RSI: 000055bf5f4af3c0 RDI: 0000000000000001 RBP: 000055bf5f4af3c0 R08: 0000000000000073 R09: 0000000000000001 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000007 R13: 00007f26906325c0 R14: 00007f269062ff20 R15: 0000000000000000 </TASK> Fixes:d5e01266e7("leds: trigger: netdev: add additional specific link speed mode") Cc: stable@vger.kernel.org Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Acked-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/fb5c8294-2a10-4bf5-8f10-3d2b77d2757e@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
621 lines
16 KiB
C
621 lines
16 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright 2017 Ben Whitten <ben.whitten@gmail.com>
|
|
// Copyright 2007 Oliver Jowett <oliver@opencloud.com>
|
|
//
|
|
// LED Kernel Netdev Trigger
|
|
//
|
|
// Toggles the LED to reflect the link and traffic state of a named net device
|
|
//
|
|
// Derived from ledtrig-timer.c which is:
|
|
// Copyright 2005-2006 Openedhand Ltd.
|
|
// Author: Richard Purdie <rpurdie@openedhand.com>
|
|
|
|
#include <linux/atomic.h>
|
|
#include <linux/ctype.h>
|
|
#include <linux/device.h>
|
|
#include <linux/ethtool.h>
|
|
#include <linux/init.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/list.h>
|
|
#include <linux/module.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <linux/timer.h>
|
|
#include "../leds.h"
|
|
|
|
#define NETDEV_LED_DEFAULT_INTERVAL 50
|
|
|
|
/*
|
|
* Configurable sysfs attributes:
|
|
*
|
|
* device_name - network device name to monitor
|
|
* interval - duration of LED blink, in milliseconds
|
|
* link - LED's normal state reflects whether the link is up
|
|
* (has carrier) or not
|
|
* tx - LED blinks on transmitted data
|
|
* rx - LED blinks on receive data
|
|
*
|
|
*/
|
|
|
|
struct led_netdev_data {
|
|
struct mutex lock;
|
|
|
|
struct delayed_work work;
|
|
struct notifier_block notifier;
|
|
|
|
struct led_classdev *led_cdev;
|
|
struct net_device *net_dev;
|
|
|
|
char device_name[IFNAMSIZ];
|
|
atomic_t interval;
|
|
unsigned int last_activity;
|
|
|
|
unsigned long mode;
|
|
int link_speed;
|
|
u8 duplex;
|
|
|
|
bool carrier_link_up;
|
|
bool hw_control;
|
|
};
|
|
|
|
static void set_baseline_state(struct led_netdev_data *trigger_data)
|
|
{
|
|
int current_brightness;
|
|
struct led_classdev *led_cdev = trigger_data->led_cdev;
|
|
|
|
/* Already validated, hw control is possible with the requested mode */
|
|
if (trigger_data->hw_control) {
|
|
led_cdev->hw_control_set(led_cdev, trigger_data->mode);
|
|
|
|
return;
|
|
}
|
|
|
|
current_brightness = led_cdev->brightness;
|
|
if (current_brightness)
|
|
led_cdev->blink_brightness = current_brightness;
|
|
if (!led_cdev->blink_brightness)
|
|
led_cdev->blink_brightness = led_cdev->max_brightness;
|
|
|
|
if (!trigger_data->carrier_link_up) {
|
|
led_set_brightness(led_cdev, LED_OFF);
|
|
} else {
|
|
bool blink_on = false;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode))
|
|
blink_on = true;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_LINK_10, &trigger_data->mode) &&
|
|
trigger_data->link_speed == SPEED_10)
|
|
blink_on = true;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_LINK_100, &trigger_data->mode) &&
|
|
trigger_data->link_speed == SPEED_100)
|
|
blink_on = true;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_LINK_1000, &trigger_data->mode) &&
|
|
trigger_data->link_speed == SPEED_1000)
|
|
blink_on = true;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &trigger_data->mode) &&
|
|
trigger_data->duplex == DUPLEX_HALF)
|
|
blink_on = true;
|
|
|
|
if (test_bit(TRIGGER_NETDEV_FULL_DUPLEX, &trigger_data->mode) &&
|
|
trigger_data->duplex == DUPLEX_FULL)
|
|
blink_on = true;
|
|
|
|
if (blink_on)
|
|
led_set_brightness(led_cdev,
|
|
led_cdev->blink_brightness);
|
|
else
|
|
led_set_brightness(led_cdev, LED_OFF);
|
|
|
|
/* If we are looking for RX/TX start periodically
|
|
* checking stats
|
|
*/
|
|
if (test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode))
|
|
schedule_delayed_work(&trigger_data->work, 0);
|
|
}
|
|
}
|
|
|
|
static bool supports_hw_control(struct led_classdev *led_cdev)
|
|
{
|
|
if (!led_cdev->hw_control_get || !led_cdev->hw_control_set ||
|
|
!led_cdev->hw_control_is_supported)
|
|
return false;
|
|
|
|
return !strcmp(led_cdev->hw_control_trigger, led_cdev->trigger->name);
|
|
}
|
|
|
|
/*
|
|
* Validate the configured netdev is the same as the one associated with
|
|
* the LED driver in hw control.
|
|
*/
|
|
static bool validate_net_dev(struct led_classdev *led_cdev,
|
|
struct net_device *net_dev)
|
|
{
|
|
struct device *dev = led_cdev->hw_control_get_device(led_cdev);
|
|
struct net_device *ndev;
|
|
|
|
if (!dev)
|
|
return false;
|
|
|
|
ndev = to_net_dev(dev);
|
|
|
|
return ndev == net_dev;
|
|
}
|
|
|
|
static bool can_hw_control(struct led_netdev_data *trigger_data)
|
|
{
|
|
unsigned long default_interval = msecs_to_jiffies(NETDEV_LED_DEFAULT_INTERVAL);
|
|
unsigned int interval = atomic_read(&trigger_data->interval);
|
|
struct led_classdev *led_cdev = trigger_data->led_cdev;
|
|
int ret;
|
|
|
|
if (!supports_hw_control(led_cdev))
|
|
return false;
|
|
|
|
/*
|
|
* Interval must be set to the default
|
|
* value. Any different value is rejected if in hw
|
|
* control.
|
|
*/
|
|
if (interval != default_interval)
|
|
return false;
|
|
|
|
/*
|
|
* net_dev must be set with hw control, otherwise no
|
|
* blinking can be happening and there is nothing to
|
|
* offloaded. Additionally, for hw control to be
|
|
* valid, the configured netdev must be the same as
|
|
* netdev associated to the LED.
|
|
*/
|
|
if (!validate_net_dev(led_cdev, trigger_data->net_dev))
|
|
return false;
|
|
|
|
/* Check if the requested mode is supported */
|
|
ret = led_cdev->hw_control_is_supported(led_cdev, trigger_data->mode);
|
|
/* Fall back to software blinking if not supported */
|
|
if (ret == -EOPNOTSUPP)
|
|
return false;
|
|
if (ret) {
|
|
dev_warn(led_cdev->dev,
|
|
"Current mode check failed with error %d\n", ret);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static void get_device_state(struct led_netdev_data *trigger_data)
|
|
{
|
|
struct ethtool_link_ksettings cmd;
|
|
|
|
trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev);
|
|
if (!trigger_data->carrier_link_up)
|
|
return;
|
|
|
|
if (!__ethtool_get_link_ksettings(trigger_data->net_dev, &cmd)) {
|
|
trigger_data->link_speed = cmd.base.speed;
|
|
trigger_data->duplex = cmd.base.duplex;
|
|
}
|
|
}
|
|
|
|
static ssize_t device_name_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
ssize_t len;
|
|
|
|
mutex_lock(&trigger_data->lock);
|
|
len = sprintf(buf, "%s\n", trigger_data->device_name);
|
|
mutex_unlock(&trigger_data->lock);
|
|
|
|
return len;
|
|
}
|
|
|
|
static int set_device_name(struct led_netdev_data *trigger_data,
|
|
const char *name, size_t size)
|
|
{
|
|
if (size >= IFNAMSIZ)
|
|
return -EINVAL;
|
|
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
/*
|
|
* Take RTNL lock before trigger_data lock to prevent potential
|
|
* deadlock with netdev notifier registration.
|
|
*/
|
|
rtnl_lock();
|
|
mutex_lock(&trigger_data->lock);
|
|
|
|
if (trigger_data->net_dev) {
|
|
dev_put(trigger_data->net_dev);
|
|
trigger_data->net_dev = NULL;
|
|
}
|
|
|
|
memcpy(trigger_data->device_name, name, size);
|
|
trigger_data->device_name[size] = 0;
|
|
if (size > 0 && trigger_data->device_name[size - 1] == '\n')
|
|
trigger_data->device_name[size - 1] = 0;
|
|
|
|
if (trigger_data->device_name[0] != 0)
|
|
trigger_data->net_dev =
|
|
dev_get_by_name(&init_net, trigger_data->device_name);
|
|
|
|
trigger_data->carrier_link_up = false;
|
|
trigger_data->link_speed = SPEED_UNKNOWN;
|
|
trigger_data->duplex = DUPLEX_UNKNOWN;
|
|
if (trigger_data->net_dev)
|
|
get_device_state(trigger_data);
|
|
|
|
trigger_data->last_activity = 0;
|
|
|
|
set_baseline_state(trigger_data);
|
|
mutex_unlock(&trigger_data->lock);
|
|
rtnl_unlock();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t device_name_store(struct device *dev,
|
|
struct device_attribute *attr, const char *buf,
|
|
size_t size)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
int ret;
|
|
|
|
ret = set_device_name(trigger_data, buf, size);
|
|
|
|
if (ret < 0)
|
|
return ret;
|
|
return size;
|
|
}
|
|
|
|
static DEVICE_ATTR_RW(device_name);
|
|
|
|
static ssize_t netdev_led_attr_show(struct device *dev, char *buf,
|
|
enum led_trigger_netdev_modes attr)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
int bit;
|
|
|
|
switch (attr) {
|
|
case TRIGGER_NETDEV_LINK:
|
|
case TRIGGER_NETDEV_LINK_10:
|
|
case TRIGGER_NETDEV_LINK_100:
|
|
case TRIGGER_NETDEV_LINK_1000:
|
|
case TRIGGER_NETDEV_HALF_DUPLEX:
|
|
case TRIGGER_NETDEV_FULL_DUPLEX:
|
|
case TRIGGER_NETDEV_TX:
|
|
case TRIGGER_NETDEV_RX:
|
|
bit = attr;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
return sprintf(buf, "%u\n", test_bit(bit, &trigger_data->mode));
|
|
}
|
|
|
|
static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
|
|
size_t size, enum led_trigger_netdev_modes attr)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
unsigned long state, mode = trigger_data->mode;
|
|
int ret;
|
|
int bit;
|
|
|
|
ret = kstrtoul(buf, 0, &state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
switch (attr) {
|
|
case TRIGGER_NETDEV_LINK:
|
|
case TRIGGER_NETDEV_LINK_10:
|
|
case TRIGGER_NETDEV_LINK_100:
|
|
case TRIGGER_NETDEV_LINK_1000:
|
|
case TRIGGER_NETDEV_HALF_DUPLEX:
|
|
case TRIGGER_NETDEV_FULL_DUPLEX:
|
|
case TRIGGER_NETDEV_TX:
|
|
case TRIGGER_NETDEV_RX:
|
|
bit = attr;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (state)
|
|
set_bit(bit, &mode);
|
|
else
|
|
clear_bit(bit, &mode);
|
|
|
|
if (test_bit(TRIGGER_NETDEV_LINK, &mode) &&
|
|
(test_bit(TRIGGER_NETDEV_LINK_10, &mode) ||
|
|
test_bit(TRIGGER_NETDEV_LINK_100, &mode) ||
|
|
test_bit(TRIGGER_NETDEV_LINK_1000, &mode)))
|
|
return -EINVAL;
|
|
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
trigger_data->mode = mode;
|
|
trigger_data->hw_control = can_hw_control(trigger_data);
|
|
|
|
set_baseline_state(trigger_data);
|
|
|
|
return size;
|
|
}
|
|
|
|
#define DEFINE_NETDEV_TRIGGER(trigger_name, trigger) \
|
|
static ssize_t trigger_name##_show(struct device *dev, \
|
|
struct device_attribute *attr, char *buf) \
|
|
{ \
|
|
return netdev_led_attr_show(dev, buf, trigger); \
|
|
} \
|
|
static ssize_t trigger_name##_store(struct device *dev, \
|
|
struct device_attribute *attr, const char *buf, size_t size) \
|
|
{ \
|
|
return netdev_led_attr_store(dev, buf, size, trigger); \
|
|
} \
|
|
static DEVICE_ATTR_RW(trigger_name)
|
|
|
|
DEFINE_NETDEV_TRIGGER(link, TRIGGER_NETDEV_LINK);
|
|
DEFINE_NETDEV_TRIGGER(link_10, TRIGGER_NETDEV_LINK_10);
|
|
DEFINE_NETDEV_TRIGGER(link_100, TRIGGER_NETDEV_LINK_100);
|
|
DEFINE_NETDEV_TRIGGER(link_1000, TRIGGER_NETDEV_LINK_1000);
|
|
DEFINE_NETDEV_TRIGGER(half_duplex, TRIGGER_NETDEV_HALF_DUPLEX);
|
|
DEFINE_NETDEV_TRIGGER(full_duplex, TRIGGER_NETDEV_FULL_DUPLEX);
|
|
DEFINE_NETDEV_TRIGGER(tx, TRIGGER_NETDEV_TX);
|
|
DEFINE_NETDEV_TRIGGER(rx, TRIGGER_NETDEV_RX);
|
|
|
|
static ssize_t interval_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
|
|
return sprintf(buf, "%u\n",
|
|
jiffies_to_msecs(atomic_read(&trigger_data->interval)));
|
|
}
|
|
|
|
static ssize_t interval_store(struct device *dev,
|
|
struct device_attribute *attr, const char *buf,
|
|
size_t size)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
unsigned long value;
|
|
int ret;
|
|
|
|
if (trigger_data->hw_control)
|
|
return -EINVAL;
|
|
|
|
ret = kstrtoul(buf, 0, &value);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* impose some basic bounds on the timer interval */
|
|
if (value >= 5 && value <= 10000) {
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
atomic_set(&trigger_data->interval, msecs_to_jiffies(value));
|
|
set_baseline_state(trigger_data); /* resets timer */
|
|
}
|
|
|
|
return size;
|
|
}
|
|
|
|
static DEVICE_ATTR_RW(interval);
|
|
|
|
static ssize_t offloaded_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev);
|
|
|
|
return sprintf(buf, "%d\n", trigger_data->hw_control);
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(offloaded);
|
|
|
|
static struct attribute *netdev_trig_attrs[] = {
|
|
&dev_attr_device_name.attr,
|
|
&dev_attr_link.attr,
|
|
&dev_attr_link_10.attr,
|
|
&dev_attr_link_100.attr,
|
|
&dev_attr_link_1000.attr,
|
|
&dev_attr_full_duplex.attr,
|
|
&dev_attr_half_duplex.attr,
|
|
&dev_attr_rx.attr,
|
|
&dev_attr_tx.attr,
|
|
&dev_attr_interval.attr,
|
|
&dev_attr_offloaded.attr,
|
|
NULL
|
|
};
|
|
ATTRIBUTE_GROUPS(netdev_trig);
|
|
|
|
static int netdev_trig_notify(struct notifier_block *nb,
|
|
unsigned long evt, void *dv)
|
|
{
|
|
struct net_device *dev =
|
|
netdev_notifier_info_to_dev((struct netdev_notifier_info *)dv);
|
|
struct led_netdev_data *trigger_data =
|
|
container_of(nb, struct led_netdev_data, notifier);
|
|
|
|
if (evt != NETDEV_UP && evt != NETDEV_DOWN && evt != NETDEV_CHANGE
|
|
&& evt != NETDEV_REGISTER && evt != NETDEV_UNREGISTER
|
|
&& evt != NETDEV_CHANGENAME)
|
|
return NOTIFY_DONE;
|
|
|
|
if (!(dev == trigger_data->net_dev ||
|
|
(evt == NETDEV_CHANGENAME && !strcmp(dev->name, trigger_data->device_name)) ||
|
|
(evt == NETDEV_REGISTER && !strcmp(dev->name, trigger_data->device_name))))
|
|
return NOTIFY_DONE;
|
|
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
mutex_lock(&trigger_data->lock);
|
|
|
|
trigger_data->carrier_link_up = false;
|
|
trigger_data->link_speed = SPEED_UNKNOWN;
|
|
trigger_data->duplex = DUPLEX_UNKNOWN;
|
|
switch (evt) {
|
|
case NETDEV_CHANGENAME:
|
|
get_device_state(trigger_data);
|
|
fallthrough;
|
|
case NETDEV_REGISTER:
|
|
dev_put(trigger_data->net_dev);
|
|
dev_hold(dev);
|
|
trigger_data->net_dev = dev;
|
|
break;
|
|
case NETDEV_UNREGISTER:
|
|
dev_put(trigger_data->net_dev);
|
|
trigger_data->net_dev = NULL;
|
|
break;
|
|
case NETDEV_UP:
|
|
case NETDEV_CHANGE:
|
|
get_device_state(trigger_data);
|
|
break;
|
|
}
|
|
|
|
set_baseline_state(trigger_data);
|
|
|
|
mutex_unlock(&trigger_data->lock);
|
|
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
/* here's the real work! */
|
|
static void netdev_trig_work(struct work_struct *work)
|
|
{
|
|
struct led_netdev_data *trigger_data =
|
|
container_of(work, struct led_netdev_data, work.work);
|
|
struct rtnl_link_stats64 *dev_stats;
|
|
unsigned int new_activity;
|
|
struct rtnl_link_stats64 temp;
|
|
unsigned long interval;
|
|
int invert;
|
|
|
|
/* If we dont have a device, insure we are off */
|
|
if (!trigger_data->net_dev) {
|
|
led_set_brightness(trigger_data->led_cdev, LED_OFF);
|
|
return;
|
|
}
|
|
|
|
/* If we are not looking for RX/TX then return */
|
|
if (!test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) &&
|
|
!test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode))
|
|
return;
|
|
|
|
dev_stats = dev_get_stats(trigger_data->net_dev, &temp);
|
|
new_activity =
|
|
(test_bit(TRIGGER_NETDEV_TX, &trigger_data->mode) ?
|
|
dev_stats->tx_packets : 0) +
|
|
(test_bit(TRIGGER_NETDEV_RX, &trigger_data->mode) ?
|
|
dev_stats->rx_packets : 0);
|
|
|
|
if (trigger_data->last_activity != new_activity) {
|
|
led_stop_software_blink(trigger_data->led_cdev);
|
|
|
|
invert = test_bit(TRIGGER_NETDEV_LINK, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_LINK_10, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_LINK_100, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_LINK_1000, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &trigger_data->mode) ||
|
|
test_bit(TRIGGER_NETDEV_FULL_DUPLEX, &trigger_data->mode);
|
|
interval = jiffies_to_msecs(
|
|
atomic_read(&trigger_data->interval));
|
|
/* base state is ON (link present) */
|
|
led_blink_set_oneshot(trigger_data->led_cdev,
|
|
&interval,
|
|
&interval,
|
|
invert);
|
|
trigger_data->last_activity = new_activity;
|
|
}
|
|
|
|
schedule_delayed_work(&trigger_data->work,
|
|
(atomic_read(&trigger_data->interval)*2));
|
|
}
|
|
|
|
static int netdev_trig_activate(struct led_classdev *led_cdev)
|
|
{
|
|
struct led_netdev_data *trigger_data;
|
|
unsigned long mode = 0;
|
|
struct device *dev;
|
|
int rc;
|
|
|
|
trigger_data = kzalloc(sizeof(struct led_netdev_data), GFP_KERNEL);
|
|
if (!trigger_data)
|
|
return -ENOMEM;
|
|
|
|
mutex_init(&trigger_data->lock);
|
|
|
|
trigger_data->notifier.notifier_call = netdev_trig_notify;
|
|
trigger_data->notifier.priority = 10;
|
|
|
|
INIT_DELAYED_WORK(&trigger_data->work, netdev_trig_work);
|
|
|
|
trigger_data->led_cdev = led_cdev;
|
|
trigger_data->net_dev = NULL;
|
|
trigger_data->device_name[0] = 0;
|
|
|
|
trigger_data->mode = 0;
|
|
atomic_set(&trigger_data->interval, msecs_to_jiffies(NETDEV_LED_DEFAULT_INTERVAL));
|
|
trigger_data->last_activity = 0;
|
|
|
|
/* Check if hw control is active by default on the LED.
|
|
* Init already enabled mode in hw control.
|
|
*/
|
|
if (supports_hw_control(led_cdev)) {
|
|
dev = led_cdev->hw_control_get_device(led_cdev);
|
|
if (dev) {
|
|
const char *name = dev_name(dev);
|
|
|
|
set_device_name(trigger_data, name, strlen(name));
|
|
trigger_data->hw_control = true;
|
|
|
|
rc = led_cdev->hw_control_get(led_cdev, &mode);
|
|
if (!rc)
|
|
trigger_data->mode = mode;
|
|
}
|
|
}
|
|
|
|
led_set_trigger_data(led_cdev, trigger_data);
|
|
|
|
rc = register_netdevice_notifier(&trigger_data->notifier);
|
|
if (rc)
|
|
kfree(trigger_data);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static void netdev_trig_deactivate(struct led_classdev *led_cdev)
|
|
{
|
|
struct led_netdev_data *trigger_data = led_get_trigger_data(led_cdev);
|
|
|
|
unregister_netdevice_notifier(&trigger_data->notifier);
|
|
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
led_set_brightness(led_cdev, LED_OFF);
|
|
|
|
dev_put(trigger_data->net_dev);
|
|
|
|
kfree(trigger_data);
|
|
}
|
|
|
|
static struct led_trigger netdev_led_trigger = {
|
|
.name = "netdev",
|
|
.activate = netdev_trig_activate,
|
|
.deactivate = netdev_trig_deactivate,
|
|
.groups = netdev_trig_groups,
|
|
};
|
|
|
|
module_led_trigger(netdev_led_trigger);
|
|
|
|
MODULE_AUTHOR("Ben Whitten <ben.whitten@gmail.com>");
|
|
MODULE_AUTHOR("Oliver Jowett <oliver@opencloud.com>");
|
|
MODULE_DESCRIPTION("Netdev LED trigger");
|
|
MODULE_LICENSE("GPL v2");
|