Gaurav Kohli de3d7ff3ec tracing: Fix race in trace_open and buffer resize call ...

commit bbeb97464e upstream.

Below race can come, if trace_open and resize of
cpu buffer is running parallely on different cpus
CPUX                                CPUY
				    ring_buffer_resize
				    atomic_read(&buffer->resize_disabled)
tracing_open
tracing_reset_online_cpus
ring_buffer_reset_cpu
rb_reset_cpu
				    rb_update_pages
				    remove/insert pages
resetting pointer

This race can cause data abort or some times infinte loop in
rb_remove_pages and rb_insert_pages while checking pages
for sanity.

Take buffer lock to fix this.

Link: https://lkml.kernel.org/r/1601976833-24377-1-git-send-email-gkohli@codeaurora.org

Cc: stable@vger.kernel.org
Fixes: b23d7a5f4a ("ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU")
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-11-05 11:51:41 +01:00

..

blktrace.c

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

bpf_trace.c

bpf: Remove inline from bpf_do_trace_printk

2020-08-06 16:53:17 -07:00

bpf_trace.h

bpf: Use dedicated bpf_trace_printk event instead of trace_printk()

2020-07-13 16:55:49 -07:00

fgraph.c

tracing: Define MCOUNT_INSN_SIZE when not defined without direct calls

2020-01-02 21:56:44 -05:00

ftrace_internal.h

x86/ftrace: Have ftrace trampolines turn read-only at the end of system boot up

2020-05-12 18:24:34 -04:00

ftrace.c

ftrace: Move RCU is watching check after recursion check

2020-09-29 13:05:10 -04:00

Kconfig

Merge tag 'trace-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

2020-06-09 10:06:18 -07:00

kprobe_event_gen_test.c

tracing: Add kprobe event command generation test module

2020-01-30 09:46:28 -05:00

Makefile

Merge tag 'kbuild-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild

2020-08-09 14:10:26 -07:00

power-traces.c

…

preemptirq_delay_test.c

tracing: Wait for preempt irq delay thread to execute

2020-05-11 17:00:34 -04:00

ring_buffer_benchmark.c

sched,tracing: Convert to sched_set_fifo()

2020-07-29 11:43:53 +02:00

ring_buffer.c

tracing: Fix race in trace_open and buffer resize call

2020-11-05 11:51:41 +01:00

rpm-traces.c

…

synth_event_gen_test.c

tracing: Have synthetic event test use raw_smp_processor_id()

2020-02-20 17:43:41 -05:00

trace_benchmark.c

trace: Use pr_warn instead of pr_warning

2019-10-18 15:01:57 +02:00

trace_benchmark.h

…

trace_boot.c

tracing/boottime: Fix kprobe multiple events

2020-06-23 21:51:50 -04:00

trace_branch.c

tracing: Make struct ring_buffer less ambiguous

2020-01-13 13:19:38 -05:00

trace_clock.c

…

trace_dynevent.c

tracing: Use seq_buf for building dynevent_cmd string

2020-02-01 13:10:15 -05:00

trace_dynevent.h

tracing: Remove check_arg() callbacks from dynevent args

2020-02-01 13:09:23 -05:00

trace_entries.h

tracing: Make ftrace packed events have align of 1

2020-06-16 21:21:02 -04:00

trace_event_perf.c

Merge branch 'perf/urgent' into perf/core, to pick up fixes

2019-10-28 12:38:26 +01:00

trace_events_filter_test.h

…

trace_events_filter.c

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

trace_events_hist.c

tracing: fix double free

2020-09-18 13:16:40 -04:00

trace_events_inject.c

tracing: Initialize val to zero in parse_entry of inject code

2020-01-02 19:04:57 -05:00

trace_events_synth.c

tracing, synthetic events: Replace buggy strcat() with seq_buf operations

2020-11-05 11:51:10 +01:00

trace_events_trigger.c

tracing: Fix event trigger to accept redundant spaces

2020-06-23 21:51:40 -04:00

trace_events.c

tracing: Use trace_sched_process_free() instead of exit() for pid tracing

2020-08-04 20:15:07 -04:00

trace_export.c

tracing: Make ftrace packed events have align of 1

2020-06-16 21:21:02 -04:00

trace_functions_graph.c

ring-buffer: Rename ring_buffer_read() to read_buffer_iter_advance()

2020-03-19 19:11:19 -04:00

trace_functions.c

trace: Fix typo in allocate_ftrace_ops()'s comment

2020-06-16 21:21:02 -04:00

trace_hwlat.c

tracing/hwlat: Honor the tracing_cpumask

2020-07-30 19:35:04 -04:00

trace_irqsoff.c

tracing: Rename trace_buffer to array_buffer

2020-01-13 13:19:38 -05:00

trace_kdb.c

tracing: Rename trace_buffer to array_buffer

2020-01-13 13:19:38 -05:00

trace_kprobe_selftest.c

…

trace_kprobe_selftest.h

…

trace_kprobe.c

maccess: rename probe_user_{read,write} to copy_{from,to}_user_nofault

2020-06-17 10:57:41 -07:00

trace_mmiotrace.c

tracing: Make struct ring_buffer less ambiguous

2020-01-13 13:19:38 -05:00

trace_nop.c

…

trace_output.c

tracing: Make the space reserved for the pid wider

2020-09-18 12:42:11 -04:00

trace_output.h

…

trace_preemptirq.c

lockdep: fix order in trace_hardirqs_off_caller()

2020-09-14 10:08:07 +02:00

trace_printk.c

tracing: Add locked_down checks to the open calls of files created for tracefs

2019-10-12 20:48:06 -04:00

trace_probe_tmpl.h

…

trace_probe.c

tracing/probe: Fix memleak in fetch_op_data operations

2020-06-16 21:21:02 -04:00

trace_probe.h

tracing/probe: Replace zero-length array with flexible-array

2020-06-15 23:08:32 -05:00

trace_sched_switch.c

tracing: Fix sched switch start/stop refcount racy updates

2020-01-30 09:46:10 -05:00

trace_sched_wakeup.c

tracing: Make struct ring_buffer less ambiguous

2020-01-13 13:19:38 -05:00

trace_selftest_dynamic.c

…

trace_selftest.c

tracing: Rename trace_buffer to array_buffer

2020-01-13 13:19:38 -05:00

trace_seq.c

tracing: Remove unused TRACE_SEQ_BUF_USED

2020-01-21 18:39:54 -05:00

trace_stack.c

trace: fix an incorrect __user annotation on stack_trace_sysctl

2020-06-08 10:13:56 -04:00

trace_stat.c

tracing: Fix tracing_stat return values in error handling paths

2020-01-24 18:06:48 -05:00

trace_stat.h

tracing: Use generic type for comparator function

2019-11-14 13:15:11 -05:00

trace_synth.h

tracing: Move synthetic events to a separate file

2020-06-01 08:23:22 -04:00

trace_syscalls.c

Merge tag 'trace-v5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

2020-02-06 07:12:11 +00:00

trace_uprobe.c

tracing/uprobe: Remove dead code in trace_uprobe_register()

2020-08-03 16:16:46 -04:00

trace.c

tracing: Fix trace_find_next_entry() accounting of temp buffer size

2020-09-29 12:46:22 -04:00

trace.h

ftrace: Fix ftrace_trace_task return value

2020-08-03 16:12:31 -04:00

tracing_map.c

tracing: Convert local functions in tracing_map.c to static

2020-04-22 22:07:26 -04:00

tracing_map.h

…