Takashi Iwai 716132e00c ALSA: usb-audio: Add error checks for usb_driver_claim_interface() calls ...

[ Upstream commit 5fb45414ae ]

There are a few calls of usb_driver_claim_interface() but all of those
miss the proper error checks, as reported by Coverity.  This patch
adds those missing checks.

Along with it, replace the magic pointer with -1 with a constant
USB_AUDIO_IFACE_UNUSED for better readability.

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1475943 ("Error handling issues")
Addresses-Coverity-ID: 1475944 ("Error handling issues")
Addresses-Coverity-ID: 1475945 ("Error handling issues")
Fixes: b1ce7ba619 ("ALSA: usb-audio: claim autodetected PCM interfaces all at once")
Fixes: e5779998bf ("ALSA: usb-audio: refactor code")
Link: https://lore.kernel.org/r/202104051059.FB7F3016@keescook
Link: https://lore.kernel.org/r/20210406113534.30455-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-05-14 09:50:33 +02:00

..

6fire

sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv()

2020-09-25 16:33:59 +02:00

bcd2000

ALSA: bcd2000: More constifications

2020-01-05 16:14:49 +01:00

caiaq

ALSA: Replace with fallthrough pseudo keyword in the remaining places

2020-07-09 19:10:43 +02:00

hiface

sound: hiface: move to use usb_control_msg_send()

2020-09-25 16:33:59 +02:00

line6

sound: line6: move to use usb_control_msg_send() and usb_control_msg_recv()

2020-09-25 16:33:59 +02:00

misc

ALSA: ua101: Replace tasklet with work

2020-09-09 18:33:15 +02:00

usx2y

sound: usx2y: move to use usb_control_msg_send()

2020-09-25 16:33:59 +02:00

card.c

ALSA: usb-audio: Add error checks for usb_driver_claim_interface() calls

2021-05-14 09:50:33 +02:00

card.h

ALSA: usb-audio: work around streaming quirk for MacroSilicon MS2109

2020-08-10 12:57:12 +02:00

clock.c

ALSA: usb-audio: Explicitly set up the clock selector

2021-05-11 14:47:32 +02:00

clock.h

ALSA: usb-audio: Add clock validity quirk for Denon MC7000/MCX8000

2020-02-13 07:18:58 +01:00

debug.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

endpoint.c

ALSA: usb-audio: Don't avoid stopping the stream at disconnection

2021-03-20 10:43:44 +01:00

endpoint.h

ALSA: usb-audio: Improve frames size computation

2020-04-24 08:25:24 +02:00

format.c

ALSA: usb-audio: Fix potential out-of-bounds shift

2020-12-21 13:30:07 +01:00

format.h

ALSA: usb: initial USB Audio Device Class 3.0 support

2018-03-21 11:46:33 +01:00

helper.c

USB: move snd_usb_pipe_sanity_check into the USB core

2020-09-16 11:02:23 +02:00

helper.h

USB: move snd_usb_pipe_sanity_check into the USB core

2020-09-16 11:02:23 +02:00

Kconfig

sound: Fix Kconfig indentation

2019-10-07 03:53:03 +02:00

Makefile

ALSA: usb-audio: Add support for Presonus Studio 1810c

2020-02-15 09:46:16 +01:00

media.c

media: sound/usb: Use Media Controller API to share media resources

2019-04-22 11:21:06 -04:00

media.h

media: sound/usb: Use Media Controller API to share media resources

2019-04-22 11:21:06 -04:00

midi.c

ALSA: usb-audio: Fix UBSAN warnings for MIDI jacks

2021-01-12 20:18:20 +01:00

midi.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mixer_maps.c

ALSA: usb-audio: Add dB range mapping for Sennheiser Communications Headset PC 8

2021-05-11 14:47:32 +02:00

mixer_quirks.c

ALSA: usb-audio: Fix unintentional sign extension issue

2021-03-25 09:04:07 +01:00

mixer_quirks.h

ALSA: usb-audio: Initialize Dell Dock playback volumes

2018-05-02 16:02:32 +02:00

mixer_s1810c.c

ALSA: usb-audio: Fix some typos

2020-06-30 19:48:18 +02:00

mixer_s1810c.h

ALSA: usb-audio: Add support for Presonus Studio 1810c

2020-02-15 09:46:16 +01:00

mixer_scarlett_gen2.c

Merge tag 'sound-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound

2020-10-15 11:07:44 -07:00

mixer_scarlett_gen2.h

ALSA: usb-audio: Scarlett Gen 2 mixer interface

2019-07-28 17:47:48 +02:00

mixer_scarlett.c

ALSA: usb-audio: More constifications

2020-01-05 16:14:34 +01:00

mixer_scarlett.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mixer_us16x08.c

ALSA: usb-audio: US16x08: fix value count for level meters

2020-11-27 14:56:40 +01:00

mixer_us16x08.h

ALSA: usb: Constify snd_kcontrol_new items

2020-01-03 09:24:34 +01:00

mixer.c

ALSA: usb-audio: Drop bogus dB range in too low level

2021-03-09 11:11:10 +01:00

mixer.h

ALSA: usb-audio: Fix OOB access of mixer element list

2020-06-24 14:24:29 +02:00

pcm.c

ALSA: usb-audio: Don't avoid stopping the stream at disconnection

2021-03-20 10:43:44 +01:00

pcm.h

ALSA: usb-audio: Add UAC3 Power Domains to suspend/resume

2018-07-31 15:01:36 +02:00

power.c

ALSA: usb-audio: More validations of descriptor units

2019-08-22 10:35:59 +02:00

power.h

ALSA: usb-audio: Initial Power Domain support

2018-07-31 15:01:22 +02:00

proc.c

ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats()

2020-04-22 11:29:15 +02:00

proc.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

quirks-table.h

ALSA: usb-audio: Add MIDI quirk for Vox ToneLab EX

2021-05-07 11:04:33 +02:00

quirks.c

ALSA: usb-audio: Add error checks for usb_driver_claim_interface() calls

2021-05-14 09:50:33 +02:00

quirks.h

ALSA: usb-audio: Rewrite registration quirk handling

2020-03-26 10:47:00 +01:00

stream.c

ALSA: usb-audio: Fix control 'access overflow' errors from chmap

2020-12-21 13:30:07 +01:00

stream.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

usbaudio.h

ALSA: usb-audio: Add error checks for usb_driver_claim_interface() calls

2021-05-14 09:50:33 +02:00

validate.c

ALSA: usb-audio: Fix endianess in descriptor validation

2020-02-01 09:06:11 +01:00